fix null crash with mounted check

[krushnarout]

Line of code, what is the cause that leads to this fix? Which variable is potentially null?

omi/app/lib/pages/onboarding/find_device/found_devices.dart

Line 174 in 575d674

await showDialog(

here dialog was called after async work, that's why State.context becomes null after the widget is disposed

closes #3801

[gemini-code-assist]

Code Review

This pull request effectively resolves a null crash that occurred when displaying a firmware warning. The primary fix involves adding a mounted check before showing the dialog, which is a critical safeguard to prevent using the widget's context after it has been unmounted, especially in asynchronous operations. Additionally, the code quality is improved by using a distinct dialogContext within the dialog builder, which avoids variable shadowing and ensures the dialog is dismissed using the correct context. These changes make the code more robust and stable.

[beastoin]

with every single fix, you must include the cause at the loc level.

For example, what is the cause that leads to this fix? Which variable is potentially null?

---

[krushnarout]

with every single fix, you must include the cause at the loc level.

For example, what is the cause that leads to this fix? Which variable is potentially null?

added #3802 (comment)

[beastoin]

I don't see that these lines of code match the bug reports. Can you check it again?

[krushnarout]

I don't see that these lines of code match the bug reports. Can you check it again?

@beastoin I added the line of code that actually causes the crash, which is await showDialog(context: context, ...). In the bug report, _0x0 _FoundDevicesState._showFirmwareWarningIfNeeded + 157 (found_devices.dart:157) only points to the function where the error occurred, not the exact statement.

[mdmohsin7]

pls resolve conflicts

[krushnarout]

pls resolve conflicts

done