fix conversation grouping null crash #3766
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a critical bug where incorrect conversation details could be displayed due to improper handling of null returns from getConversationDateAndIndex. The review includes suggestions to ensure robust state management within the conversation_provider.dart method, aligning with the principle that provider methods should handle state management to prevent UI-level data inconsistencies. This ensures the detail page always displays the correct conversation, preventing potential data corruption or user confusion.
| // Ensure the provider has the conversation data from the widget parameter | ||
| provider.setCachedConversation(widget.conversation); | ||
|
|
||
| conversationProvider.groupConversationsByDate(); |
There was a problem hiding this comment.
why do we have to group them here?
There was a problem hiding this comment.
so that grouped state exists before both index lookup and updates, preventing wrong indexing and null crash
There was a problem hiding this comment.
@mdmohsin7 man don't hesitate with @krushnarout and feel free to merge the PR once you see it's good.
|
@mdmohsin7 fixed conflicts, pls review thank you |
closes #3764