Generic backport support#175
Merged
Barracuda09 merged 3 commits intoBarracuda09:masterfrom Nov 24, 2022
Merged
Conversation
Contributor
Author
|
Hi @Barracuda09 , This PR implements your suggestion in #164 (comment) . My idea is to update the corresponding diff file when a I'll do a new commit for the PR #173. And when a new PR will be created (because an outdated patch) then modify the Makefile and replace the patch file with a new one. You agree with that? |
Contributor
Author
|
Hi @Barracuda09 , Still waiting for the merging of this PR and closing the #164. Regards. |
Barracuda09
reviewed
Nov 17, 2022
Owner
Barracuda09
left a comment
Barracuda09
left a comment
There was a problem hiding this comment.
Nice! Thanks!
Will merge as soon as possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables a new Makefile option that patches the code for supporting non-C++17 compilers.