-
Notifications
You must be signed in to change notification settings - Fork 0
updated votemarket integration, remove bribe split logic #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gosuto-inzasheru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly a lot of removes, i can follow most of it. test run is reassuring and lgtm
|
proposing tiny additional refactor: #273 |
…factory refactor: remove redundant factory
Co-authored-by: gosuto.eth <gosuto@inzasheru.email>
Xeonus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New logic simplifying bribe flow and correctly assigns incentives for various edge cases, including Balancer alliance
handles #270
depends on BalancerMaxis/bal_tools#156
-removes aura/bal split logic
-remove hh and paladin bribe platform impls
-
replace hh min threshold calc with stakedao version- moved to bal_tools-update how we interface with stakedao to handle automatic internal split, aura and bal only bribes
-other deprecated, misc stuff removed
test run: #272