Skip to content

fix: dao fees should go to treasury #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gosuto-inzasheru merged 6 commits into from
Nov 6, 2025
Merged

fix: dao fees should go to treasury #237

gosuto-inzasheru merged 6 commits into from
Nov 6, 2025

Conversation

@gosuto-inzasheru
Copy link
Contributor

@gosuto-inzasheru gosuto-inzasheru commented Oct 30, 2025 •
edited
Loading

@gosuto-inzasheru gosuto-inzasheru mentioned this pull request Oct 30, 2025
Merged
@Xeonus
Copy link
Contributor

Xeonus commented Oct 30, 2025

@gosuto-inzasheru the current target is not correct. Fees need to flow to the Balancer Onchain Limited safe at 0x16b0056636Fcc85f92C49cD49a24bc519d4A1941

Xeonus
Xeonus requested changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@Xeonus Xeonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change target to Balancer Onchain lmt safe as per BIP-882 specs

Xeonus
Xeonus requested changes Oct 30, 2025
View reviewed changes
fee_allocator/payload_visualizer.py Outdated
if recipient == self.book.get("maxiKeepers/veBalFeeInjector", "").lower():
groups["veBAL Transfers"].append(tx)
elif recipient == self.book.get("multisigs/dao", "0x10A19e7eE7d7F8a52822f6817de8ea18204F2e4f").lower():
elif recipient == self.book.get("multisigs/kpk_managed", "0x0EFcCBb9E2C09Ea29551879bd9Da32362b32fc89").lower():
Copy link
Contributor

@Xeonus Xeonus Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update bal_addresses with Balancer Onchain and other safes

@gosuto-inzasheru @Xeonus
fix: use balancer onchain ltd msig as fee recipient
25cfe0a 
Co-authored-by: Xeonus <vanderbourg@gmail.com>
@gosuto-inzasheru
Copy link
Contributor Author

gosuto-inzasheru commented Oct 31, 2025

@jalbrekt85 can you have a look, test is now failing on gql.transport.exceptions.TransportQueryError: {'message': 'Variable "$where" got invalid value "EZKL" at "where.poolTypeIn[0]"; Value "EZKL" does not exist in "GqlPoolType" enum.', 'locations': [{'line': 1, 'column': 24}], 'extensions': {'code': 'BAD_USER_INPUT'}}

@gosuto-inzasheru
Copy link
Contributor Author

gosuto-inzasheru commented Oct 31, 2025

relies on BalancerMaxis/bal_addresses#794

Xeonus
Xeonus approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@Xeonus Xeonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jalbrekt85
Copy link
Collaborator

jalbrekt85 commented Oct 31, 2025

@jalbrekt85 can you have a look, test is now failing on gql.transport.exceptions.TransportQueryError: {'message': 'Variable "$where" got invalid value "EZKL" at "where.poolTypeIn[0]"; Value "EZKL" does not exist in "GqlPoolType" enum.', 'locations': [{'line': 1, 'column': 24}], 'extensions': {'code': 'BAD_USER_INPUT'}}

will be fixed upon merging #236. that started happening after ezkl was added to the partner config: BalancerMaxis/multisig-ops#2492, but the logic to handle this has not been merged yet

@jalbrekt85
Copy link
Collaborator

jalbrekt85 commented Nov 3, 2025 •
edited
Loading

wlll approve after i am able to run locally and verify new label in report. currently blocked by #236

@gosuto-inzasheru gosuto-inzasheru merged commit c4f6206 into biweekly-runs Nov 6, 2025
4 checks passed
@gosuto-inzasheru gosuto-inzasheru deleted the fix/dao-fees-treasury branch November 6, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xeonus Xeonus Xeonus approved these changes

@jalbrekt85 jalbrekt85 Awaiting requested review from jalbrekt85

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gosuto-inzasheru @Xeonus @jalbrekt85