remove pyudev #19
Merged
remove pyudev #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
need to check and implement for macos as well. Looks like this is working on linux but needs some cleanup |
talhaHavadar
force-pushed
the
sparse/talhaHavadar/remove-pyudev/slice/3
branch
from
dbf50a9 to
30b02ca
Compare
This commit removes the need for pyudev to detect block devices which removes a blocker for this tool to run on operating systems that dont have udev (namely windows,macos, etc.). This also enables `--version` option for the cli and it fetches the information from pyproject.toml file
talhaHavadar
force-pushed
the
sparse/talhaHavadar/remove-pyudev/slice/3
branch
from
30b02ca to
254b61f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10