The new About page for the website!#36
Open
Sahil2004 wants to merge 7 commits intoBRL-CAD:masterfrom
Sahil2004:about-page
Open
The new About page for the website!#36Sahil2004 wants to merge 7 commits intoBRL-CAD:masterfrom Sahil2004:about-page
Sahil2004 wants to merge 7 commits intoBRL-CAD:masterfrom
Sahil2004:about-page
Conversation
These are the three images for the new about page. All the images are free and open-sourced. The link from where I have picked them is given in the about.html page uploaded, next to the image reference using <img> tag.
Member
|
Sahil, this looks pretty good except that you don't link any of the existing pages to your about page. Add another commit (to this same pull request, not a new/additional one) where you link in your page on the site menu bar. |
Changed and corrected the links on the page!
Updated the links for the about page!
Member
|
It looks like you updated the link to an invalid link (about vs about.html)... Did you test your changes? |
Author
|
Oh, sorry! I just forgot that I had to do about.html and not merely about! I actually did it in GitHub and didn't test the changes. But I have now checked the changes and did it! |
Member
|
This looks fixed, thanks! |
starseeker
force-pushed
the
master
branch
2 times, most recently
from
147a43c to
2578f26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are three images attached to the page!
All the images are free or open-sourced images.