Create DateI18n.lua for date string processing

[Bapham12]

Add DateI18n module for processing date strings.

[graphite-app]

Crash when month is nil. If datecode is 'Y' (year only), month will be nil (from line 252: datenum[2]). However, if a case parameter is provided (line 277 check passes), the code calls MonthCase(month, case, lang) at line 281 with nil month. This causes T[month][case] at line 217 to attempt indexing T[nil], resulting in a crash.

-- Add nil check for month
if month and (case ~= '') then
    local monthMsg = MonthCase(month, case, lang)
    if monthMsg and monthMsg ~= '' then
        dFormat = strReplace(dFormat, 'F',  '"'..monthMsg..'"')
        dFormat = strReplace(dFormat, 'xg', '"'..monthMsg..'"')
    end
end

Suggested change

	local monthMsg = MonthCase(month, case, lang)
	if monthMsg and monthMsg ~= '' then -- make sure it exists
	dFormat = strReplace(dFormat, 'F', '"'..monthMsg..'"') -- replace default month with month name we already looked up
	dFormat = strReplace(dFormat, 'xg', '"'..monthMsg..'"')
	end
	if month and (case ~= '') then
	local monthMsg = MonthCase(month, case, lang)
	if monthMsg and monthMsg ~= '' then -- make sure it exists
	dFormat = strReplace(dFormat, 'F', '"'..monthMsg..'"') -- replace default month with month name we already looked up
	dFormat = strReplace(dFormat, 'xg', '"'..monthMsg..'"')
	end
	end

Spotted by Graphite Agent



Is this helpful? React 👍 or 👎 to let us know.

This comment came from an experimental review—please leave feedback if it was helpful/unhelpful. Learn more about experimental comments here.