Implement Formatnum module in Lua #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module replaces Template:Formatnum functionality with a Lua implementation, providing number formatting based on language and precision.
Removed Luacheck linter step from workflow.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+108
to
+110
| if prec > 0 then | ||
| local zero = language:formatNum(0) | ||
| number = number .. dot .. mw.ustring.rep(zero, prec) |
There was a problem hiding this comment.
Uses ASCII dot '.' as decimal separator after language localization, causing incorrect formatting for languages that use different decimal separators (e.g., comma in French/German).
When dot = '.' (set on line 92 when the original number had no decimal point), this appends an ASCII period even though language:formatNum() already localized the number. For example, with French locale:
- Input: "3", precision: 2
- Expected: "3,00"
- Actual: "3.00" (wrong separator)
Fix by extracting the localized decimal separator:
if prec > 0 then
local zero = language:formatNum(0)
-- Extract localized decimal separator
local decimal_sep = language:formatNum(1.5):sub(2, 2)
if dot ~= '' then
decimal_sep = '' -- already has separator
end
number = number .. decimal_sep .. mw.ustring.rep(zero, prec)
Suggested change
| if prec > 0 then | |
| local zero = language:formatNum(0) | |
| number = number .. dot .. mw.ustring.rep(zero, prec) | |
| if prec > 0 then | |
| local zero = language:formatNum(0) | |
| -- Extract localized decimal separator | |
| local decimal_sep = language:formatNum(1.5):sub(2, 2) | |
| if dot ~= '' then | |
| decimal_sep = '' -- already has separator | |
| end | |
| number = number .. decimal_sep .. mw.ustring.rep(zero, prec) |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module replaces Template:Formatnum functionality with a Lua implementation, providing number formatting based on language and precision.