Added Feedback system to the Blog #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
title and content always required.
|
Could you please update the PR according to the template? |
default rating is zero.
star rating system
update rating and sort the blog according to the feedback
added feedback button
anandbhardwaj1
changed the title
| console.log(errors); | ||
| if (!errors.isEmpty()) { | ||
|
|
||
| res.send(500); |
Member
There was a problem hiding this comment.
Errors are sent with a message in this format:
return res.status(400).json({ msg: 'Empty request' });
| // console.log(req.body.nodes[0].content); | ||
|
|
||
| } | ||
| else{ |
Member
There was a problem hiding this comment.
Use try and catch blocks for error handling btw. This helps in sending error responses for all sorts of errors, instead of sending individual response for particular errors.
| }); | ||
|
|
||
|
|
||
| router.get("/posterror", function (req, res) { |
Member
There was a problem hiding this comment.
Don't write a separate route just for errors. Errors should be written for each individual route.
| {upsert:false}, | ||
|
|
||
| function(err, document){ | ||
|
|
Member
There was a problem hiding this comment.
You can write a simple console.log here cause otherwise there's no purpose of an error handling function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title and other contents always required.
Added Feedback Model which will help readers to go through the best content first i.e blogs are arranged according to their overall ratings.
Motivation
(Write your motivation here.)
Have you read the Contributing Guidelines on issues?
yes
Test Plan
i have tested on my local server.
Related PRs and Issues
#16
#12