refactor: Updated core functionality with hooks #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- migrated to react hooks - updated types to allow pass custom interfaces - updated README with typescript example - refactored README headings levels
Fixed issue with setting and initialization attributes like "id", "src".
Contributor
Author
|
I'm working on required updates |
Contributor
Author
|
Funny thing, but I refactored to this, and it works well: import React, { forwardRef } from 'react';
const reactifyWebComponent = <WebComponentProps,>(WebComponentName: string) => {
type ReactWebComponentProps = React.HTMLProps<HTMLElement> &
WebComponentProps;
return forwardRef<HTMLElement, ReactWebComponentProps>((props, parentRef) => (
<WebComponentName ref={parentRef} {...(props as ReactWebComponentProps)} />
));
};
export default reactifyWebComponent;@BBKolton Could you take a look and test it before I push it here? Because it seems weird for me, and I fell like I missed something. |
Collaborator
|
Sorry for the delay. I will take a look into this a bit more. Thank you for helping :) |
|
Any update on this PR? |
Contributor
Author
|
if some maintainer would review it, I'm ready to make this up to date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋
Played a bit with your package and faced with the same problem as described here #15. Decided to help and here we are 🎉
What I noted is the current structure looks not really well 😕. One react project nested to another it's not a good idea, so probably good to think about a different approach for testing. And one more thing... I found installed testing library, but it's not used as well, and it also affects to described issue. More details here: testing-library/react-testing-library#570
This PR broke the current test environment 🙃 because of the new version of react and hooks. There is some workaround how it's possible to test locally. Let me know if it's interesting for you, but I'd prefer to focus on replacing this structure and testing env, with something more or less modern, or at least with something that will work 😄
Changes:
Related