Skip to content

draft: potential crash fixes#22

Merged
AzureDoom merged 2 commits intoAzureDoom:mainfrom
IroriPowered:work/crash-fixes
Feb 19, 2026
Merged

draft: potential crash fixes#22
AzureDoom merged 2 commits intoAzureDoom:mainfrom
IroriPowered:work/crash-fixes

Conversation

@KabanFriends
Copy link
Contributor

📌 Description

Tries to fix getPlayer deadlock described in #17. Although the exact cause of the deadlock is still unclear, I cleaned up the code a little bit to reduce the amount of World.execute() calls, and it seems to have drastically improved the issue.

I can't really explain why exactly this reduced crashes, but feel free to look at the changes and merge if you'd like.

Fixes #17 (issue)


🧪 Type of Change

Please check the types of changes your PR introduces:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Tests added / updated

👩‍💻 Implementation Details

Removed some redundant calls for World.execute(). Since the code already runs on a system that's meant to run on the world thread, excessive re-scheduling shouldn't be needed.


✅ Checklist

Go over all the following items and check them before submitting your PR:

  • My code follows the project’s code style (simply run spotlessApply to apply formatting)
  • I have performed a self-review of my own code
  • I have commented my code where necessary
  • My changes generate no new warnings

(This is a draft PR, so things should be re-checked later)


⛓ Related Issues

Link any related issues or PRs here:

@AzureDoom
Copy link
Owner

Thanks! Im out until the 20th here but will see about merging this after #21 when I am back!

@AzureDoom AzureDoom self-assigned this Feb 17, 2026
@AzureDoom AzureDoom added the bug Something isn't working label Feb 17, 2026
@AzureDoom
Copy link
Owner

LGTM and no merge conflicts with other pr! Release window set for this weekend!

@AzureDoom AzureDoom merged commit a99977f into AzureDoom:main Feb 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Random world deadlock on NEARBY_PLAYERS_MEAN calculation

2 participants

Comments