Merged
Conversation
Owner
|
Thanks! Im out until the 20th here but will see about merging this after #21 when I am back! |
Owner
|
LGTM and no merge conflicts with other pr! Release window set for this weekend! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Tries to fix
getPlayerdeadlock described in #17. Although the exact cause of the deadlock is still unclear, I cleaned up the code a little bit to reduce the amount ofWorld.execute()calls, and it seems to have drastically improved the issue.I can't really explain why exactly this reduced crashes, but feel free to look at the changes and merge if you'd like.
Fixes #17 (issue)
🧪 Type of Change
Please check the types of changes your PR introduces:
👩💻 Implementation Details
Removed some redundant calls for
World.execute(). Since the code already runs on a system that's meant to run on the world thread, excessive re-scheduling shouldn't be needed.✅ Checklist
Go over all the following items and check them before submitting your PR:
spotlessApplyto apply formatting)(This is a draft PR, so things should be re-checked later)
⛓ Related Issues
Link any related issues or PRs here: