fix: support multi-layer inheritance in hierarchyBuilding decorator #3801
+145
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@hierarchyBuildingdecorator was failing validation when skipping multiple inheritance layers. It only checked direct properties on the target model, not inherited properties.Previously this would report a warning that A is missing property
cand the decorator would not apply.Changes
decorators.ts: AddedgetAllPropertiesInChain()to collect all properties from a model's inheritance chain. UpdatedisPropertySuperset()to validate against inherited properties, not just direct properties.types.ts: When legacy hierarchy building skips intermediate models, properties from those skipped models are now "collapsed" into the target SDK type.Result
Model A now correctly:
a(own) andb(from skipped model B)cWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
telemetry.astro.build/usr/local/bin/node node /home/REDACTED/work/typespec-azure/typespec-azure/website/node_modules/.bin/../astro/astro.js build node ical/node_modules/.bin/../@typespec/tspd/cmd/tspd.js tput-dir ../../website/src/content/docs/docs/emitters/protobuf/reference . .0_tmp_3782/node_modules/pnpm/dist/node-gyp-bin/sh ern-signature &&sh ce n/sh sh c-az�� tput-dir ../../website/src/conte--llmstxt node n/sh perimental gen-esh gen-extern-signa-c ager/reference node(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
hierarchyBuildingdecorator to support multiple layer inheritance replacement #3737💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.