-
Notifications
You must be signed in to change notification settings - Fork 67
Fix: populate resultSegments in method.response for @markAsPageable #3800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
9
commits into
main
Choose a base branch
from
copilot/fix-result-segments-population
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+93
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecorator Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
packages/typespec-client-generator-core/test/decorators/mark-as-pageable.test.ts
Outdated
Show resolved
Hide resolved
…rray Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix resultSegments not populated in method.response
Fix: populate resultSegments in method.response for @markAsPageable
Jan 19, 2026
Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
packages/typespec-client-generator-core/test/decorators/mark-as-pageable.test.ts
Outdated
Show resolved
Hide resolved
Member
ArcturusZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot please resolve the comment and add a changeset
Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
Contributor
Author
ArcturusZhang
approved these changes
Jan 19, 2026
Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
ArcturusZhang
approved these changes
Jan 19, 2026
Member
|
@copilot please fix the build error |
Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
Contributor
Author
commit: |
tadelesh
approved these changes
Jan 19, 2026
tadelesh
reviewed
Jan 19, 2026
Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
tadelesh
approved these changes
Jan 19, 2026
Member
|
@copilot fix the format issue reported in CI |
Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
baseServiceMethod.response.resultSegmentsassignment for @markAsPageable casecontext.__pagedResultSet.add(responseType)call for @markAsPageable to match normal paging behaviorOriginal prompt
resultSegmentsis not populated inmethod.responsewhen there is a@markAsPageabledecorator #3799💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.