Revert @identifiers decorator and deprecate x-ms-identifiers generation #3779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove @Identifiers decorator from typespec-azure-resource-manager - Remove automatic x-ms-identifiers generation from @key decorator - Remove x-ms-identifiers generation logic from typespec-autorest - Revert to using @OpenAPI.extension("x-ms-identifiers", ...) - Remove related tests for @Identifiers decorator - Update documentation to reflect the changes - Add deprecation changelog entry This reverts changes introduced in PR #1983
qiaozha
requested review from
bterlson,
markcowl and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
lib:azure-resource-manager
Collaborator
|
All changed packages have been documented.
Show changes
|
- Remove identifiers.test.ts that references deleted functions - Replace @Identifiers with @OpenAPI.extension in library files - Disable missing-x-ms-identifiers rule (mark as deprecated) - Update rule message to indicate deprecation
…schema, regenerate samples
microsoft-github-policy-service
bot
added
the
lib:azure-core
commit: |
Collaborator
|
You can try these changes here
|
markcowl
added
the
breaking-change
timotheeguerin
requested changes
Jan 15, 2026
Member
There was a problem hiding this comment.
@qiaozha before this happens we need full confirmation from ARM team that this is uncesssary and this change cannot be done in such a breaking manner. It needs to be rolled out following the process we've established.
- deprecate only
- migrate everything in spec repo
- remove 1-2 sprint later
timotheeguerin
added
the
int:azure-specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reverts the changes introduced in PR #1983 which added the @Identifiers decorator and automatic x-ms-identifiers generation from @key decorator.
Changes
Related Issues
Reverts: #1983
Breaking Changes