Order the release of application parent chart#238
Open
nitishm wants to merge 11 commits intoAzure:mainfrom
Open
Order the release of application parent chart#238nitishm wants to merge 11 commits intoAzure:mainfrom
nitishm wants to merge 11 commits intoAzure:mainfrom
Conversation
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #238 +/- ##
==========================================
- Coverage 31.31% 31.20% -0.12%
==========================================
Files 5 5
Lines 1025 1032 +7
==========================================
+ Hits 321 322 +1
- Misses 676 682 +6
Partials 28 28
Continue to review full report at Codecov.
|
jonathan-innis
suggested changes
May 15, 2021
Contributor
jonathan-innis
left a comment
jonathan-innis
left a comment
There was a problem hiding this comment.
Couple small asks
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
Contributor
Author
|
@jonathan-innis are we good to merge this? |
jonathan-innis
suggested changes
May 19, 2021
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
…om/nitishm/orkestra into nitishm/enh/235/order-parent-chart
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #235
Signed-off-by: Nitish Malhotra nitish.malhotra@gmail.com