-
Notifications
You must be signed in to change notification settings - Fork 64
meta-iotedge: revert aziot-edged and iotedge to 1.5.21 #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta-iotedge: revert aziot-edged and iotedge to 1.5.21 #197
Conversation
IoT Edge 1.5.35 only updates container images. The daemon components (aziot-edged and iotedge) remain at version 1.5.21 per upstream product-versions.json and release notes. The 1.5.35 daemon recipes cause runtime failures due to attempts to pull non-existent images such as: mcr.microsoft.com/azureiotedge-diagnostics:1.5.35 This change reverts the daemon recipe versions back to 1.5.21 and aligns meta-iotedge with the official Azure IoT Edge 1.5.35 version matrix. Signed-off-by: Rafał Ilnicki <r.ilnicki@welotec.com>
|
@microsoft-github-policy-service agree company="Welotec" |
|
Thanks for catching this! We will also need to update our automation accordingly. Looks like a small change. Have you tested this recipe on your side as well? |
|
Yes, I build an image with these changes and connected to IoT Hub using a primary connection string. |
The release tag (e.g. 1.5.35) may only update Docker images while the
daemon binaries (aziot-edged, iotedge) stay at an earlier version
(e.g. 1.5.21 per product-versions.json). Using the release tag as the
recipe version caused runtime failures:
Unable to find image 'mcr.microsoft.com/azureiotedge-diagnostics:1.5.35'
Changes:
update-recipes.sh:
- Extracts 'aziot-edge' component version (daemon version) from
product-versions.json and uses it for recipe filenames, VERSION
export, and SRCREV resolution
- Stores the release tag as IOTEDGE_RELEASE in the version .inc
file for traceability
check-upstream.sh:
- Reads IOTEDGE_RELEASE from the .inc file to determine if the
current release is already tracked, preventing false 'docker-only'
notifications when the release is already handled
- Outputs current_release and update_type for workflow use
ci-build.yml:
- check-recipes job reads IOTEDGE_RELEASE from .inc to determine
which release tag to pass to update-recipes.sh for idempotency
watch-upstream.yml:
- notify-docker-only condition uses update_type instead of comparing
recipe filename version against release version
- Adds current_release and update_type outputs
Fixes #197
|
Thanks for catching this @rilnicki. The root cause is that This manual fix is correct and unblocks the release. I have also added the automation fix to #196 so that Approving -- let us merge this to unblock the release and land the automation fix via #196 separately. |
jlian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Correct fix for the daemon version mismatch.
The release tag (e.g. 1.5.35) may only update Docker images while the
daemon binaries (aziot-edged, iotedge) stay at an earlier version
(e.g. 1.5.21 per product-versions.json). Using the release tag as the
recipe version caused runtime failures:
Unable to find image 'mcr.microsoft.com/azureiotedge-diagnostics:1.5.35'
Changes:
update-recipes.sh:
- Extracts 'aziot-edge' component version (daemon version) from
product-versions.json and uses it for recipe filenames, VERSION
export, and SRCREV resolution
- Stores the release tag as IOTEDGE_RELEASE in the version .inc
file for traceability
check-upstream.sh:
- Reads IOTEDGE_RELEASE from the .inc file to determine if the
current release is already tracked, preventing false 'docker-only'
notifications when the release is already handled
- Outputs current_release and update_type for workflow use
ci-build.yml:
- check-recipes job reads IOTEDGE_RELEASE from .inc to determine
which release tag to pass to update-recipes.sh for idempotency
watch-upstream.yml:
- notify-docker-only condition uses update_type instead of comparing
recipe filename version against release version
- Adds current_release and update_type outputs
Fixes #197
|
Re-tagged and re-released The tag stays |
IoT Edge 1.5.35 only updates container images. The daemon components (aziot-edged and iotedge) remain at version 1.5.21 per upstream product-versions.json and release notes.
https://github.com/Azure/azure-iotedge/blob/1.5.35/product-versions.json
The 1.5.35 daemon recipes cause runtime failures due to attempts to pull non-existent images such as: mcr.microsoft.com/azureiotedge-diagnostics:1.5.35
This change reverts the daemon recipe versions back to 1.5.21 and aligns meta-iotedge with the official Azure IoT Edge 1.5.35 version matrix.