failed closed on three eno annotations if they parse bad. add tests b… #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut still some failures
jveski
reviewed
Jul 8, 2025
| reconcileInterval, err := time.ParseDuration(str) | ||
| if anno[reconcileIntervalKey] != "" && err != nil { | ||
| logger.V(0).Info("invalid reconcile interval - ignoring") | ||
| return nil, fmt.Errorf("invalid reconcile interval, %s", str) |
Collaborator
There was a problem hiding this comment.
I think it's safe to make these terminal errors but we should add an integration test in the reconciliation controller to prove that producing invalid resources doesn't cause a deadlock state e.g. synthesis is blocked because the previous synthesis is invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ut still some failures