fix: correct chatAdapterOptions handling inside useAzureCommunicationChatAdapter#6050
Open
neilcampbell wants to merge 1 commit intoAzure:mainfrom
Open
fix: correct chatAdapterOptions handling inside useAzureCommunicationChatAdapter#6050neilcampbell wants to merge 1 commit intoAzure:mainfrom
neilcampbell wants to merge 1 commit intoAzure:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Forward
chatAdapterOptionsfrom theuseAzureCommunicationChatAdapterhook args to the underlyingcreateAzureCommunicationChatAdaptercall.Why
chatAdapterOptionsis destructured from the hook'sargsparameter but is never passed through when creating the adapter. This means any options provided by the caller (e.g., custom topic fetching behaviour) are silently ignored.How Tested
AzureCommunicationChatAdapter.test.tsand all other test suites).rush build,rush lint, andrush testsuccessfully.Process & policy checklist
Is this a breaking change?
No