Skip to content

fix: correct chatAdapterOptions handling inside useAzureCommunicationChatAdapter#6050

Open
neilcampbell wants to merge 1 commit intoAzure:mainfrom
neilcampbell:fix/chat-adapter-options
Open

fix: correct chatAdapterOptions handling inside useAzureCommunicationChatAdapter#6050
neilcampbell wants to merge 1 commit intoAzure:mainfrom
neilcampbell:fix/chat-adapter-options

Conversation

@neilcampbell
Copy link

What

Forward chatAdapterOptions from the useAzureCommunicationChatAdapter hook args to the underlying createAzureCommunicationChatAdapter call.

Why

chatAdapterOptions is destructured from the hook's args parameter but is never passed through when creating the adapter. This means any options provided by the caller (e.g., custom topic fetching behaviour) are silently ignored.

How Tested

  • Existing unit tests pass (AzureCommunicationChatAdapter.test.ts and all other test suites).
  • Ran rush build, rush lint, and rush test successfully.

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?
No

@neilcampbell
Copy link
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments