Skip to content

Conversation

@weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Jan 30, 2026

Here is a run with timeout (after I add timeout logic, and before I set timeout to minimal 5min)
Screenshot 2026-01-30 142206
Now it can report as failed.

Also, I've set a minimal timeout as 5*60. When running a small number (say 1) of generate scripts/tasks, it is quite possible that 1 script/task takes more than 1min.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review January 30, 2026 06:27
Copilot AI review requested due to automatic review settings January 30, 2026 06:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes timeout handling in the code generation comparison script by properly detecting when generation jobs time out and treating timeouts as failures.

Changes:

  • Introduces a configurable script timeout (60 seconds per script) with a minimum timeout of 5 minutes
  • Adds timeout detection logic to check if jobs are still running after the wait period
  • Updates the exit condition to fail the script when a timeout occurs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant