[AutoPR azure-resourcemanager-resources-deploymentstacks]-generated-from-SDK Generation - Java-5803514 #47817
Conversation
…esources/deploymentStacks/tspconfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '652ad4cb131256f10a90ea2df207b38cf35d6671' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5803514 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
bot
added
the
Mgmt
kalbert312
requested review from
a team,
ArthurMa1978,
XiaofeiCao and
haolingdong-msft
as code owners
There was a problem hiding this comment.
Pull request overview
This is an automated SDK generation PR that updates the Azure Deployment Stacks resource manager library from AutoRest to TypeSpec code generation, introducing API version 2025-07-01. The PR represents a stable release (1.1.0) of the deployment stacks library with significant API enhancements.
Changes:
- Migration from AutoRest to TypeSpec code generator with updated attribution comments throughout
- Introduction of new WhatIf API operations for previewing deployment stack changes across subscription, resource group, and management group scopes
- Addition of deployment extension support with configuration models
- API breaking changes including removal of UnmanageAction* enum types replaced by unified DeploymentStacksDeleteDetachEnum
Reviewed changes
Copilot reviewed 97 out of 157 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/resources/azure-resourcemanager-resources/README.md | Updates version reference to 2.54.0-beta.1 |
| sdk/resources/azure-resourcemanager-resources/CHANGELOG.md | Critical Issue: Incorrectly changes version to 1.1.0 (wrong library) |
| sdk/resources/azure-resourcemanager-resources-deploymentstacks/tsp-location.yaml | Adds TypeSpec location configuration |
| sdk/resources/azure-resourcemanager-resources-deploymentstacks/src/test/** | Adds comprehensive test coverage for new models and APIs |
| sdk/resources/azure-resourcemanager-resources-deploymentstacks/src/samples/** | Adds usage samples for new WhatIf APIs |
| sdk/resources/azure-resourcemanager-resources-deploymentstacks/src/main/** | Migrates to TypeSpec-generated code with new WhatIf and extension models |
| sdk/resources/azure-resourcemanager-resources-deploymentstacks/pom.xml | Updates to version 1.1.0 and TypeSpec attribution |
| eng/versioning/version_client.txt | Updates version tracking for deployment stacks library |
| # Release History | ||
|
|
||
| ## 2.54.0-beta.1 (Unreleased) | ||
| ## 1.1.0 (Unreleased) |
There was a problem hiding this comment.
The CHANGELOG version has been changed from "2.54.0-beta.1" to "1.1.0" which appears to be incorrect. Based on the README.md change showing version 2.54.0-beta.1 for the parent resources library, this CHANGELOG entry seems to belong to a different library (azure-resourcemanager-resources-deploymentstacks). The CHANGELOG.md for azure-resourcemanager-resources should maintain its own version sequence.
There was a problem hiding this comment.
This part will be fixed by Xiaofei. It is a bug on script.
| * Deployment stack properties. | ||
| * Resource tags. | ||
| */ | ||
| private DeploymentStackProperties properties; |
There was a problem hiding this comment.
This is a regression from TypeSpec change Azure/azure-rest-api-specs@05584a1#diff-af9f7d24ca45fab50c14fc90c723c2d7a51300b70746299f8a21b557228f455d
dev will need to do a fix Azure/azure-rest-api-specs#39970 and regen.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews com.azure.resourcemanager:azure-resourcemanager-resources-deploymentstacks |
|
Hi @kalbert312 , I saw a break from your migration. Before, in Swagger, there is 3 different enum ( Now in TypeSpec, you only have 1 single This would be a break that likely cannot be mitigated by SDK. Are you sure this is correct? PS: the naming |
…esources/deploymentStacks/tspconfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '9762f2dd848f6955a855f5dbe8c4df8f4d5dfd66' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5807045 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
I guess we can revert this to avoid customer confusion. The justification was that this is a single enum on the backend (which is named "CleanupActionType" which is a better name, I agree the name is bad). The justification for keeping them as separate types is if one of them diverged and accepted a different action type, this would be more easily scoped by the SDK. |
|
|
Thanks. I've approved it. Also asked dev from other languages to comment (especially if any of them do not want this fix). |
3 participants
Configurations: 'specification/resources/resource-manager/Microsoft.Resources/deploymentStacks/tspconfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '652ad4cb131256f10a90ea2df207b38cf35d6671' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5803514 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=0a321955-acfb-f011-8406-000d3a3ac981 Submitted by: kylealbert@microsoft.com
Release Plan Details
Spec pull request: [Microsoft.Resources] Deployment Stacks next stable API version 2025-07-01 azure-rest-api-specs#36828
Spec API version: 2025-07-01