[AutoPR azure-resourcemanager-containerregistry-tasks]-generated-from-SDK Generation - Java-5780623 #47769
Conversation
…rosoft.ContainerRegistry/RegistryTasks/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: '3f223d61b02c0496581dfb71c78104761b448d5e' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5780623 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
bot
added
Container Registry
Mgmt
|
@XiaofeiCao Why containerregistrytasks get generated into containerregistry folder? |
|
Namespace review PR Azure/azure-sdk#9151 Note that it is 4 segments. So the service-dir is correct. It is the package name / namespace wrong in tspconfig.yaml, dev will need to fix there first. |
…ager/Microsoft.ContainerRegistry/RegistryTasks/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: '3f223d61b02c0496581dfb71c78104761b448d5e' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5780623 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release." This reverts commit 5513fc7.
…rosoft.ContainerRegistry/RegistryTasks/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: 'b98ebeb5250e9af1846b14884677ac71aeb2be53' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5783998 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
There was a problem hiding this comment.
Script bug?
I think file in azure-resourcemanager-containerregistry should not be modified in the PR.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews com.azure.resourcemanager:azure-resourcemanager-containerregistry-tasks |
weidongxu-microsoft
requested review from
a team,
ArthurMa1978,
alzimmermsft and
haolingdong-msft
as code owners
There was a problem hiding this comment.
Pull request overview
This PR introduces the initial release of the Azure Resource Manager Container Registry Tasks client library for Java, generated from the TypeSpec specification for API version 2025-03-01-preview. The library provides create, read, update, and delete functionality for Azure Container Registry tasks-related resources including agent pools, runs, task runs, and tasks.
Changes:
- Added new
azure-resourcemanager-containerregistry-tasksmodule with generated code for Container Registry Tasks management - Implemented model classes for task operations, run configurations, source control, triggers, and agent pool management
- Added fluent client interfaces and implementation classes for REST API operations
Reviewed changes
Copilot reviewed 108 out of 204 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Maven project configuration for the new containerregistry-tasks module |
| README.md | Documentation with setup instructions and authentication examples |
| CHANGELOG.md | Initial release notes for version 1.0.0-beta.1 |
| eng/versioning/version_client.txt | Version tracking entry for the new module |
| models/* | Generated model classes for tasks, runs, triggers, source control, and agent pools |
| fluent/* | Client interfaces and inner model classes for REST operations |
| implementation/* | Implementation classes for client operations and resource management |
weidongxu-microsoft
changed the title
| /** | ||
| * Static value 386 for Architecture. | ||
| */ | ||
| public static final Architecture THREE_EIGHT_SIX = fromString("386"); |
There was a problem hiding this comment.
Any suggestion for naming in Java?
Java does not allow variable name start with number, so codegen automatically convert 386 to text. This is not very appropriate for this scenario.
When checking AI, it gives options like "I386" or "X86" (this already in enum above).
There was a problem hiding this comment.
We can see JS changed it too (that got my attention)
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/RegistryTasks/client.tsp#L12
5 participants
Configurations: 'specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/RegistryTasks/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: '3f223d61b02c0496581dfb71c78104761b448d5e' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5780623 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=2a608315-60f6-f011-8406-000d3a376cbb Submitted by: clarkporter@microsoft.com
Release Plan Details
Spec pull request: [Typespec Migration] migrate control plane containerregistry to typespec azure-rest-api-specs#37169
Spec API version: 2025-03-01-preview