-
Notifications
You must be signed in to change notification settings - Fork 148
Sync eng/common directory with azure-sdk-tools for PR 12734 #6814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the cspell package configuration to standardize the package naming and pin the exact version. The changes rename the package to use the @azure-tools scope, mark it as private, and pin the cspell dependency to an exact version rather than using a caret range.
Key Changes:
- Renamed package from "cspell-version-pin" to "@azure-tools/cspell"
- Added
"private": trueto prevent accidental publication - Changed cspell dependency from
^9.2.1(caret range) to9.2.1(exact version)
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/spelling/package.json | Updated package name to scoped name, added private flag, and pinned cspell to exact version |
| eng/common/spelling/package-lock.json | Synchronized lock file with package.json changes for name and version pinning |
Files not reviewed (1)
- eng/common/spelling/package-lock.json: Language not supported
| { | ||
| "name": "cspell-version-pin", | ||
| "name": "@azure-tools/cspell", | ||
| "version": "1.0.0", |
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version field should be removed from package-lock.json when the package is marked as private and not intended for publication, or it should be kept in sync with package.json. Currently, package.json is missing the version field but package-lock.json still includes it, creating an inconsistency.
| "version": "1.0.0", |
|
Hi @azure-sdk. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12734 See eng/common workflow