Update timezone during specialization #845
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedmuhsin
requested review from
TsuyoshiUshio,
gavin-aguiar,
hallvictoria,
swapnil-nagar and
vrdmr
as code owners
| * Sets the default timezone based on the TZ environment variable | ||
| */ | ||
| private void setTimeZone(Map<String, String> environmentVariables) { | ||
| String tzValue = environmentVariables.get("TZ"); |
Contributor
There was a problem hiding this comment.
I think we should also check for this app setting: WEBSITE_TIME_ZONE
Contributor
Author
There was a problem hiding this comment.
Updated logic so that we first look at WEBSITE_TIME_ZONE and then fallback on TZ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for setting the timezone during specialization in Azure Functions workers, addressing timezone handling as part of the function app lifecycle. In addition to the core timezone update, a set of complementary testing and infrastructure improvements are included, primarily focused on test modularity and reusability.
Timezone Support During Specialization:
TimezoneCheck) is added to demonstrate timezone detection and validation, along with its Maven configuration and Functions host settings. [1] [2] [3]Azure Functions Test Kit Package:
azure-functions-test-kitwith apyproject.tomlfor packaging and dependency management. This package exposes classes to conveniently manage Azurite, Functions containers, and the Linux Consumption test environment. [1] [2] [3] [4]plugin. py) that automatically loads.envfiles for test configuration, eliminating the need for custom fixtures inconftest.py. [1] [2]Test Environment Refactoring:
utils/linux_consumption_test_environment. pytoazure_functions_test_kit/environments/consumption.py. Improvements include: modular design, easier imports, context manager support, and aurlproperty for simplified use in tests. [1] [2] [3] [4] [5]Summary:
The primary change is robust timezone configuration during function app specialization. All additional modifications—such as the introduction of the
azure-functions-test-kitand related test refactoring—are supporting updates to make local testing, sample development, and test environment setup more modular and consistent.