{Compute} az vm availability-set create: Migrate commands to aaz #32679
+75,692
−22,541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiii99
requested review from
jsntcy,
wangzelin007 and
yanzhudd
as code owners
❌AzureCLI-FullTest
|
|
Hi @huiii99, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the az vm availability-set create command from using ARM template-based deployment to the AAZ (Azure CLI Code Generation) framework. The migration deprecates the --validate parameter since the command no longer generates ARM templates.
Changes:
- Replaced ARM template-based implementation with direct AAZ API calls for availability set creation
- Added deprecation notice for the
--validateparameter with a clear error message - Generated new AAZ command class in
_create.pyusing auto-generated code - Updated parameter help text to indicate the
--validateoption is deprecated
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/custom.py | Refactored create_av_set function to call AAZ Create command instead of ARM template deployment; added error handling for deprecated --validate parameter |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/availability_set/_create.py | New auto-generated AAZ command class for availability set creation using API version 2024-07-01 |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/availability_set/init.py | Added import for the new Create command class |
| src/azure-cli/azure/cli/command_modules/vm/_params.py | Updated help text for --validate parameter to indicate deprecation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az vm availability-set createDescription
This pull request migrates
az vm availability-set createcmd from the legacy mgmt.compute sdk to the new aaz framework.aaz: Azure/aaz#925
Testing Guide
History Notes
[Compute]
az vm availability-set create: Deprecate the--validateparameter after migrating the command to AAZThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.