Skip to content

Conversation

@EldertGrootenboer
Copy link

Related command
az servicebus namespace failover

Description
Clarify that this is for the new Geo-Replication feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

Copilot AI review requested due to automatic review settings January 20, 2026 20:28
@azure-client-tools-bot-prd
Copy link

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @EldertGrootenboer,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 20, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the docstring for the Azure Service Bus namespace failover command to use "Geo-Replication Failover" instead of "GeoDR Failover" to clarify that this relates to the new Geo-Replication feature.

Changes:

  • Updated class docstring from "GeoDR Failover" to "Geo-Replication Failover"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

)
class Failover(AAZCommand):
"""GeoDR Failover
"""Geo-Replication Failover
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While updating this docstring from "GeoDR" to "Geo-Replication" improves clarity, there are other occurrences of "GeoDR" in the codebase that should also be updated for consistency. Specifically:

  • src/azure-cli/azure/cli/command_modules/servicebus/aaz/latest/servicebus/namespace/_create.py line 236: "GeoDR Role Types"
  • src/azure-cli/azure/cli/command_modules/servicebus/aaz/latest/servicebus/namespace/_update.py line 99: "GeoDR Role Types"

Consider updating these references to use "Geo-Replication" terminology consistently across the module.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants