Skip to content

Conversation

@amritas
Copy link
Contributor

@amritas amritas commented Jan 21, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

nikitagarg123 and others added 30 commits January 21, 2026 17:06
* update file loc

* update version

* style fix

* style fix

---------

Co-authored-by: Nikita Garg <nikitagarg@microsoft.com>
* Removing unsupported commands from the managednetworkfabric CLI.

* updating history

* Network Cloud CLi - Fixing zip-slip vulnerability

* updating history and setup.py versions

* linting fixes

* Netowrk Cloud CLI version 2025-09-01 GA
* release 24-11

* update tests

* update version

* fix version number

* fix style

* fix style issue

* update tests

* update tests

* update tests

* update tests

* update tests

* upate test

* update test

* update test

* update test

* update commands

* update

* Update src/connectedmachine/azext_connectedmachine/aaz/latest/connectedmachine/extension/image/_show.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/connectedmachine/azext_connectedmachine/aaz/latest/connectedmachine/extension/image/_list.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* update tests

* update

* update test

* update

* update

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Ravindra Dongade <rdongade@microsoft.com>
* add pester tests for connectedk8s cli extension

* Pass the force delete param to the API call (Azure#4)

* forcedelete

* format

* add code owner

* mypy

* fix CI testcases for nodepool image issues (Azure#8)

* update python version to 3.13 (Azure#12)

* changes to support gateway association/disassociation for api version '2025-08-01-preview' (Azure#17)

* [Azure RBAC] Deprecate 3P mode flags, fix Azure RBAC enablement bug, add E2E coverage and improve logging (Azure#20)

* add pester tests for connectedk8s cli extension

* Pass the force delete param to the API call (Azure#4)

* forcedelete

* format

* add code owner

* mypy

* Parameterize for airgapped clouds (Azure#5)

* Add parameterization for the airgapped clouds

* Fix azdev style

* MCR path function

* azdev, ruff, and mypy

---------

Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com>

* Oras client fix to work with different MCRs (Azure#6)

Co-authored-by: mmcneal <mmcneal@microsoft.com>

* fix CI testcases for nodepool image issues (Azure#8)

* update errors for the config and connectivity issues (Azure#11)

* update errors

* format

* style

* update python version to 3.13 (Azure#12)

* Update cluster diagnostics image to 1.29.3 (Azure#7)

* Update cluster diagnostics helm chart to 1.29.3

* Fix lint issues

---------

Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com>

* RBAC deprecation & fix the issue

* typo

* fix comments

* update tests

* add pester tests for connectedk8s cli extension

* Pass the force delete param to the API call (Azure#4)

* forcedelete

* format

* add code owner

* mypy

* fix CI testcases for nodepool image issues (Azure#8)

* update errors for the config and connectivity issues (Azure#11)

* update errors

* format

* style

* update python version to 3.13 (Azure#12)

* rebase

* fix tests

* fix version

* fix mypy, lint

* fix test

* fix test

* fix test

* fix test

* fix test

* rename test

* deprecate flags

* rebase

* rebase

* bump version for release

---------

Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com>
Co-authored-by: Atchut Kumar Barli <atchut@gmail.com>
Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com>
Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com>
Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com>
Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com>
Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com>
Co-authored-by: vithumma <vithumma@microsoft.com>

* remove hardcoded public ARM endpoint url for fairfax and mooncake (Azure#24)

* Bug Fix for FFX mcr url  (Azure#22)

* [connectedk8s] update release notes and version (Azure#26)

* remove redundant test files

* remove change not relevant to connectedk8s release

---------

Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com>
Co-authored-by: Atchut Kumar Barli <atchut@gmail.com>
Co-authored-by: Vineeth Thumma <vineeth-thumma@users.noreply.github.com>
Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com>
Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com>
Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com>
Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com>
Co-authored-by: vithumma <vithumma@microsoft.com>
Co-authored-by: hapate <hapate@microsoft.com>
* Only attempt to parse ccePolicy if --diff is specified

* Fix parsing ccePolicies with no container defintions

* Satisfy azdev style
pagienge and others added 2 commits January 21, 2026 17:07
…from logs (Azure#9514)

* fixing repair-and-restore, restore, linter/flake8 validations

* Fixing admin user/password in logging of create command

* readme update

* Resolving copilot suggestions to comments

* fixing more linter issues

* Fixing linters, as requested

* Updated Linux images to be valid and logical for the stated tests
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jan 21, 2026

⚠️Azure CLI Extensions Breaking Change Test
⚠️trustedsigning
rule cmd_name rule_message suggest_message
⚠️ 1013 - SubgroupPropAdd trustedsigning sub group trustedsigning added property deprecate_info_hide
⚠️ 1013 - SubgroupPropAdd trustedsigning sub group trustedsigning added property deprecate_info_redirect
⚠️ 1013 - SubgroupPropAdd trustedsigning sub group trustedsigning added property deprecate_info_target

@azure-client-tools-bot-prd
Copy link

Hi @amritas,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 21, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the deprecation message for the Trustedsigning extension. Despite the title, the changes primarily consist of adding new files for the acrcssc (Azure Container Registry Container Secure Supply Chain) extension and updating test assertions in the account extension from deprecated assertEquals to assertEqual.

Changes:

  • Added comprehensive implementation for the acrcssc extension including workflow management, task operations, and continuous patching functionality
  • Updated test assertions in account extension to use assertEqual instead of deprecated assertEquals
  • Added new acat extension files including tests, setup, and utility functions

Reviewed changes

Copilot reviewed 128 out of 14434 changed files in this pull request and generated 2 comments.

File Description
src/account/azext_account/tests/latest/test_account_scenario.py Updated deprecated assertEquals to assertEqual
src/acrcssc/* Complete new extension implementation for ACR container supply chain security
src/acat/* New extension files including setup, tests, and utility functions

@@ -0,0 +1,13 @@
{
"repositories": [
{
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation detected. The file uses tabs for indentation which should be replaced with spaces (typically 2 or 4 spaces) for JSON files to maintain consistency with standard JSON formatting practices.

Copilot uses AI. Check for mistakes.
Comment on lines 3 to 10
{
"enabled": true,
"repository": "python",
"tags": [
"*"
]
}
],
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation detected. The file uses tabs for indentation which should be replaced with spaces (typically 2 or 4 spaces) for JSON files to maintain consistency with standard JSON formatting practices.

Suggested change
{
"enabled": true,
"repository": "python",
"tags": [
"*"
]
}
],
{
"enabled": true,
"repository": "python",
"tags": [
"*"
]
}
],

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@amritas amritas mentioned this pull request Jan 21, 2026
4 tasks
@github-actions
Copy link

Hi @amritas

Release Suggestions

Module: trustedsigning

  • Update VERSION to 1.0.0b3 in src/trustedsigning/setup.py

Notes

@necusjz
Copy link
Member

necusjz commented Jan 21, 2026

@amritas the commit history looks messy, please cleanup it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.