-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Trustedsigning updated deprecation message #9537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* update file loc * update version * style fix * style fix --------- Co-authored-by: Nikita Garg <nikitagarg@microsoft.com>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=140114066&view=results Last commit: Azure@351dba7
* Removing unsupported commands from the managednetworkfabric CLI. * updating history * Network Cloud CLi - Fixing zip-slip vulnerability * updating history and setup.py versions * linting fixes * Netowrk Cloud CLI version 2025-09-01 GA
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=140209385&view=results Last commit: Azure@c239b89
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=140238524&view=results Last commit: Azure@2614377
* release 24-11 * update tests * update version * fix version number * fix style * fix style issue * update tests * update tests * update tests * update tests * update tests * upate test * update test * update test * update test * update commands * update * Update src/connectedmachine/azext_connectedmachine/aaz/latest/connectedmachine/extension/image/_show.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/connectedmachine/azext_connectedmachine/aaz/latest/connectedmachine/extension/image/_list.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * update tests * update * update test * update * update --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=140341424&view=results Last commit: Azure@a9b5e3c
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=140361299&view=results Last commit: Azure@89bbdac
…less-3.3.6 ] Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=140371627&view=results Last commit: Azure@695ae60
Co-authored-by: Ravindra Dongade <rdongade@microsoft.com>
…0b1 ] Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=140490277&view=results Last commit: Azure@fe7ebde
* add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (Azure#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (Azure#8) * update python version to 3.13 (Azure#12) * changes to support gateway association/disassociation for api version '2025-08-01-preview' (Azure#17) * [Azure RBAC] Deprecate 3P mode flags, fix Azure RBAC enablement bug, add E2E coverage and improve logging (Azure#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (Azure#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (Azure#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (Azure#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (Azure#8) * update errors for the config and connectivity issues (Azure#11) * update errors * format * style * update python version to 3.13 (Azure#12) * Update cluster diagnostics image to 1.29.3 (Azure#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (Azure#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (Azure#8) * update errors for the config and connectivity issues (Azure#11) * update errors * format * style * update python version to 3.13 (Azure#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com> * remove hardcoded public ARM endpoint url for fairfax and mooncake (Azure#24) * Bug Fix for FFX mcr url (Azure#22) * [connectedk8s] update release notes and version (Azure#26) * remove redundant test files * remove change not relevant to connectedk8s release --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: Vineeth Thumma <vineeth-thumma@users.noreply.github.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com> Co-authored-by: hapate <hapate@microsoft.com>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=140504087&view=results Last commit: Azure@4253515
…ogs to monitoring addons in aks-preview (Azure#9149)
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=140506301&view=results Last commit: Azure@d2beb32
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=140510943&view=results Last commit: Azure@07cf235
Moved to - https://github.com/microsoft/integrity-vhd Removal in original location in - microsoft/hcsshim#2318
* Only attempt to parse ccePolicy if --diff is specified * Fix parsing ccePolicies with no container defintions * Satisfy azdev style
… customer-managed-key (CMK) (Azure#9301)
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=140528984&view=results Last commit: Azure@dbe4e9b
…from logs (Azure#9514) * fixing repair-and-restore, restore, linter/flake8 validations * Fixing admin user/password in logging of create command * readme update * Resolving copilot suggestions to comments * fixing more linter issues * Fixing linters, as requested * Updated Linux images to be valid and logical for the stated tests
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=149606691&view=results Last commit: Azure@054e27d
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| trustedsigning | sub group trustedsigning added property deprecate_info_hide |
||
| trustedsigning | sub group trustedsigning added property deprecate_info_redirect |
||
| trustedsigning | sub group trustedsigning added property deprecate_info_target |
|
Hi @amritas, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the deprecation message for the Trustedsigning extension. Despite the title, the changes primarily consist of adding new files for the acrcssc (Azure Container Registry Container Secure Supply Chain) extension and updating test assertions in the account extension from deprecated assertEquals to assertEqual.
Changes:
- Added comprehensive implementation for the
acrcsscextension including workflow management, task operations, and continuous patching functionality - Updated test assertions in
accountextension to useassertEqualinstead of deprecatedassertEquals - Added new
acatextension files including tests, setup, and utility functions
Reviewed changes
Copilot reviewed 128 out of 14434 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/account/azext_account/tests/latest/test_account_scenario.py | Updated deprecated assertEquals to assertEqual |
| src/acrcssc/* | Complete new extension implementation for ACR container supply chain security |
| src/acat/* | New extension files including setup, tests, and utility functions |
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "repositories": [ | |||
| { | |||
Copilot
AI
Jan 21, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent indentation detected. The file uses tabs for indentation which should be replaced with spaces (typically 2 or 4 spaces) for JSON files to maintain consistency with standard JSON formatting practices.
| { | ||
| "enabled": true, | ||
| "repository": "python", | ||
| "tags": [ | ||
| "*" | ||
| ] | ||
| } | ||
| ], |
Copilot
AI
Jan 21, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent indentation detected. The file uses tabs for indentation which should be replaced with spaces (typically 2 or 4 spaces) for JSON files to maintain consistency with standard JSON formatting practices.
| { | |
| "enabled": true, | |
| "repository": "python", | |
| "tags": [ | |
| "*" | |
| ] | |
| } | |
| ], | |
| { | |
| "enabled": true, | |
| "repository": "python", | |
| "tags": [ | |
| "*" | |
| ] | |
| } | |
| ], |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @amritas Release SuggestionsModule: trustedsigning
Notes
|
|
@amritas the commit history looks messy, please cleanup it. |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.