-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[ACR] add new acrregionalendpoint extension for private preview of ACR Regional Endpoints feature #9500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…R Regional Endpoints feature
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @lizMSFT, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds a new Azure CLI extension called "acrregionalendpoint" for the private preview of the ACR Regional Endpoints feature. The extension provides management capabilities for Azure Container Registry regional endpoints.
Key changes:
- New extension scaffolding with version 1.0.0
- Vendored Azure Container Registry Management SDK
- Support for API version 2025-12-01-preview
Reviewed changes
Copilot reviewed 38 out of 43 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Extension metadata, dependencies, and packaging configuration |
| azext_metadata.json | Extension configuration marking it as preview with minimum CLI version 2.80.0 |
| vendored_sdks/containerregistry/ | Auto-generated Container Registry Management SDK code |
| _configuration.py (sync/async) | SDK configuration with API version 2025-12-01-preview |
| models/ | Auto-generated model classes and enums for the SDK |
| operations/ | Auto-generated operation classes for SDK functionality |
| tests/ | Test structure setup (placeholder files) |
| @@ -0,0 +1,401 @@ | |||
| # -------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -0,0 +1,184 @@ | |||
| # -------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| with self.argument_context("acr create") as c: | ||
| c.argument( | ||
| "enable_regional_endpoints", | ||
| options_list=['--enable-regional-endpoints', '--regional'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment from Johnson:
--allow-* and --enable-* flags should not be used, let's go with
--regional-endpoints (enabled)|(disabled)
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az acr create/update/showaz acr show-endpointsaz acr loginaz acr importDescription
This PR is NOT READY yet. It currently uses the 2025-12-01-preview API version and will be updated to 2026-01-01-preview (with the new Python SDK) once available.
Changes Introduced:
--enable-regional-endpointsparameter toaz acr createandaz acr updatecommands to enable regional endpoint functionality.--all-endpointsparameter toaz acr logincommand to authenticate against all available regional endpoints.az acr showcommand to displayregionalEndpointEnabledandregionalEndpointHostNamesproperties in registry information.az acr show-endpointscommand to display comprehensive endpoint information including registry login server, data endpoints, and regional endpoints.az acr importcommand to automatically detect and handle regional endpoint URIs in source image specifications.Testing
az acr create:az acr update:az acr show:az acr show-endpoints:az acr login:az acr import:General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.