Skip to content

Conversation

@lizMSFT
Copy link
Member

@lizMSFT lizMSFT commented Jan 6, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az acr create/update/show
az acr show-endpoints
az acr login
az acr import

Description

This PR is NOT READY yet. It currently uses the 2025-12-01-preview API version and will be updated to 2026-01-01-preview (with the new Python SDK) once available.

Changes Introduced:

  • Add: --enable-regional-endpoints parameter to az acr create and az acr update commands to enable regional endpoint functionality.
  • Add: --all-endpoints parameter to az acr login command to authenticate against all available regional endpoints.
  • Add: Enhanced az acr show command to display regionalEndpointEnabled and regionalEndpointHostNames properties in registry information.
  • Add: Enhanced az acr show-endpoints command to display comprehensive endpoint information including registry login server, data endpoints, and regional endpoints.
  • Add: Enhanced az acr import command to automatically detect and handle regional endpoint URIs in source image specifications.

Testing

az acr create:
az_acr_create

az acr update:
az_acr_update

az acr show:
az_acr_show

az acr show-endpoints:
az_acr_show_endpoints

az acr login:
az_acr_login

az acr import:
az_acr_import

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings January 6, 2026 22:09
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @lizMSFT,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 6, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new Azure CLI extension called "acrregionalendpoint" for the private preview of the ACR Regional Endpoints feature. The extension provides management capabilities for Azure Container Registry regional endpoints.

Key changes:

  • New extension scaffolding with version 1.0.0
  • Vendored Azure Container Registry Management SDK
  • Support for API version 2025-12-01-preview

Reviewed changes

Copilot reviewed 38 out of 43 changed files in this pull request and generated no comments.

Show a summary per file
File Description
setup.py Extension metadata, dependencies, and packaging configuration
azext_metadata.json Extension configuration marking it as preview with minimum CLI version 2.80.0
vendored_sdks/containerregistry/ Auto-generated Container Registry Management SDK code
_configuration.py (sync/async) SDK configuration with API version 2025-12-01-preview
models/ Auto-generated model classes and enums for the SDK
operations/ Auto-generated operation classes for SDK functionality
tests/ Test structure setup (placeholder files)

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 7, 2026
@@ -0,0 +1,401 @@
# --------------------------------------------------------------------------------------------
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,184 @@
# --------------------------------------------------------------------------------------------
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with self.argument_context("acr create") as c:
c.argument(
"enable_regional_endpoints",
options_list=['--enable-regional-endpoints', '--regional'],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from Johnson:
--allow-* and --enable-* flags should not be used, let's go with

--regional-endpoints (enabled)|(disabled)

@lizMSFT lizMSFT requested a review from savaradh January 12, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants