Skip to content

Conversation

@Greedygre
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Same as https://github.com/Azure/azure-cli/pull/32601/files

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings January 6, 2026 03:38
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jan 6, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 6, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Hi @Greedygre

Release Suggestions

Module: containerapp

  • Update VERSION to 1.3.0b2 in src/containerapp/setup.py

Notes

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a TypeError that occurred when using az containerapp compose create with docker-compose files that include an env_file directive without an environment section. The fix is implemented by upgrading the pycomposefile dependency from version 0.0.29 to 0.0.34, which presumably handles this edge case correctly.

  • Updated the pycomposefile dependency version to fix the TypeError
  • Added changelog entry documenting the bug fix

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/containerapp/setup.py Upgraded pycomposefile dependency from >=0.0.29 to >=0.0.34 to fix TypeError
src/containerapp/HISTORY.rst Added changelog entry documenting the fix for env_file without environment scenario


# TODO: Add any additional SDK dependencies here
DEPENDENCIES = ['pycomposefile>=0.0.29', 'docker', 'kubernetes==24.2.0']
DEPENDENCIES = ['pycomposefile>=0.0.34', 'docker', 'kubernetes==24.2.0']
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency upgrade fixes a TypeError when docker-compose files include env_file without environment, but there appears to be no test coverage for this specific scenario. Consider adding a test case in test_containerapp_compose_environment.py that verifies compose create works correctly when a docker-compose file specifies env_file without an environment section.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants