-
Notifications
You must be signed in to change notification settings - Fork 96
feat(v2): Added the ability to add mcp server for Standard SKU on v2 designer. #8717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:
|
| Section | Status | Recommendation |
|---|---|---|
| Title | Update to concise imperative form and capitalize "MCP". Example: feat(v2): Add MCP server support for Standard SKU in v2 designer |
|
| Commit Type | ✅ | No change. |
| Risk Level | ✅ | Matches risk:medium. Advised: Medium. |
| What & Why | ✅ | Good; optionally add a one-line user-flow sentence. |
| Impact of Change | Expand Developers/System details as suggested above. | |
| Test Plan | ✅ | Unit tests present. Add E2E or rationale for not adding them; expand manual test notes. |
| Contributors | Add contributors or a note if none. | |
| Screenshots/Videos | ✅ | Good. |
Final message
Please update the PR title and the Impact of Change and Test Plan sections as recommended above, then re-submit. Thank you for including thorough unit tests and screenshots — this makes review much easier. If you'd like, I can propose a short edited PR title and a ready-to-paste Impact of Change snippet to include in the PR body.
Last updated: Thu, 22 Jan 2026 02:22:00 GMT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the ability to configure and add MCP (Model Context Protocol) servers for Standard SKU in the v2 designer. The implementation includes a new category for MCP servers, a browse view for selecting MCP servers, and a multi-step wizard for configuring connections and parameters before adding an MCP server to the workflow definition.
Changes:
- Added MCP wizard state management with Redux (slice, selectors, types)
- Implemented MCP server browse view with filtering and sorting capabilities
- Created connection configuration wizard with connection selection, creation, and parameter configuration steps
- Integrated MCP servers into search functionality and operation discovery
- Added comprehensive unit tests for new functionality
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
libs/logic-apps-shared/src/designer-client-services/lib/standard/connection.ts |
Enhanced MCP connection data conversion to include server URL and authentication |
libs/logic-apps-shared/src/designer-client-services/lib/standard/__tests__/connection.spec.ts |
Added unit tests for MCP connection conversion logic |
libs/designer-v2/src/lib/core/state/panel/panelTypes.ts |
Added MCP wizard state types and step constants |
libs/designer-v2/src/lib/core/state/panel/panelSlice.ts |
Implemented MCP wizard state management actions |
libs/designer-v2/src/lib/core/state/panel/panelSelectors.ts |
Added selectors for MCP wizard state |
libs/designer-v2/src/lib/core/queries/browse.ts |
Added query for fetching MCP servers |
libs/designer-v2/src/lib/ui/panel/recommendation/browse/mcpToolWizard.tsx |
Implemented multi-step wizard for MCP tool configuration |
libs/designer-v2/src/lib/ui/panel/recommendation/browse/mcpServersBrowse.tsx |
Created browse view for MCP servers with tabs and sorting |
libs/designer-v2/src/lib/ui/panel/recommendation/helpers.ts |
Added helper functions for MCP operations |
libs/designer-v2/src/lib/ui/panel/recommendation/searchView.tsx |
Integrated MCP servers into search results |
libs/designer-v2/src/lib/ui/panel/recommendation/recommendationPanelContext.tsx |
Updated panel to support MCP wizard UI |
| Multiple test files | Comprehensive unit test coverage for all new functionality |
Localize/lang/strings.json |
Added localization strings for MCP features |
libs/designer-v2/src/lib/ui/panel/recommendation/browse/__test__/mcpToolWizard.spec.tsx
Outdated
Show resolved
Hide resolved
|
📊 Coverage check completed. See workflow run for details. |
…__/mcpToolWizard.spec.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
📊 Coverage check completed. See workflow run for details. |
Commit Type
Risk Level
What & Why
Added the ability to add mcp server for Standard SKU on v2 designer. Specifically:
Impact of Change
User will be able to add mcp servers in v2 designer now for standard SKU
Test Plan
Contributors
Screenshots/Videos