Skip to content

Conversation

@anthony0t
Copy link
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Added the ability to add mcp server for Standard SKU on v2 designer. Specifically:

  1. Added a new category for mcp servers
  2. Added a browse view for mcp servers when the mcp category is selected
  3. Added a wizard when an mcp server is selected. User will be able to config connections and parameters before adding the mcp server to the definition.

Impact of Change

  • Users:
    User will be able to add mcp servers in v2 designer now for standard SKU
  • Developers:
  • System:

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in: local

Contributors

Screenshots/Videos

  1. new mcp server category
image
  1. mcp server browse view
image
  1. UI for config connections
image image
  1. UI for config parameters
image

@anthony0t anthony0t added the risk:low Low risk change with minimal impact label Jan 22, 2026
Copilot AI review requested due to automatic review settings January 22, 2026 01:59
@github-actions
Copy link

github-actions bot commented Jan 22, 2026

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

⚠️ PR Title

  • Current: feat(v2): Added the ability to add mcp server for Standard SKU on v2 designer.
  • Issue: Minor style and clarity issues: "mcp" should be capitalized as "MCP" (it's an acronym), the tense could be consistent with conventional commit style (imperative present), and the title is a bit long.
  • Recommendation: Make it concise, imperative, and capitalized. Example: feat(v2): Add MCP server support for Standard SKU in v2 designer

Commit Type

  • Properly selected (feature).
  • Note: Only one commit type is selected which is correct for a focused PR.

Risk Level

  • The PR body selects Medium and the repository labels include risk:medium. These match.
  • Advised risk level based on the code diff: Medium (many files touched across UI, state, queries, and tests — moderate scope and user impact). No change requested to the risk label.

What & Why

  • Current: "Added the ability to add mcp server for Standard SKU on v2 designer..."
  • Issue: Content is present and clear. No blocking issues.
  • Recommendation: Keep this, but optionally add one short sentence describing expected user flow (e.g., "Users can now browse MCP servers, pick/create a connection, configure parameters and add an MCP server to their workflow.").

⚠️ Impact of Change

  • The Impact section exists but is sparse. It only contains a simple Users line; Developers and System were left blank.
  • Recommendation: Expand this section with concrete impact statements:
    • Users: "Users of the v2 designer (Standard SKU) can now discover and add MCP servers via the browse UI. UX changes include a new MCP Servers category, a browse view, and a multi-step wizard for connection/parameters."
    • Developers: "New state (mcpToolWizard) and selectors added; new queries (useMcpServersQuery); new components McpServersBrowse and McpToolWizard; translations added/updated; many unit tests added. Review any consumers of panel state/selectors; update docs or internal APIs if needed."
    • System: "Small increase in bundle size and added React Query queries. Potential runtime impact: additional network calls to fetch MCP servers and tool lists; ensure backend endpoints (getMcpServers/getListDynamicValues) are resilient and properly authenticated."
      Please update the PR body Impact of Change block with those details (or similar) so reviewers / release managers understand the scope.

Test Plan

  • Unit tests: Verified in diff — multiple new unit test files were added across libs (good coverage).
  • E2E tests: Not added. If this feature requires integration/E2E validation (end-to-end flow with real MCP servers and connections), either add E2E tests or include a short explanation why manual testing suffices and what manual scenarios were exercised.
  • Manual testing: The PR indicates local testing done. Good — please add brief notes of scenarios tested locally (e.g., "Browse MCP servers, open wizard, create connection, select tools, add to workflow").

⚠️ Contributors

  • Assessment: Blank.
  • Recommendation: Add names/handles of PMs, designers, and reviewers who contributed ideas/UX work. If none, you can add a small note like "No additional contributors" — but it's helpful to credit people.

Screenshots/Videos

  • Screenshots are present in the PR body showing category, browse view, and wizard screens. Good.

Summary Table

Section Status Recommendation
Title ⚠️ Update to concise imperative form and capitalize "MCP". Example: feat(v2): Add MCP server support for Standard SKU in v2 designer
Commit Type No change.
Risk Level Matches risk:medium. Advised: Medium.
What & Why Good; optionally add a one-line user-flow sentence.
Impact of Change ⚠️ Expand Developers/System details as suggested above.
Test Plan Unit tests present. Add E2E or rationale for not adding them; expand manual test notes.
Contributors ⚠️ Add contributors or a note if none.
Screenshots/Videos Good.

Final message
Please update the PR title and the Impact of Change and Test Plan sections as recommended above, then re-submit. Thank you for including thorough unit tests and screenshots — this makes review much easier. If you'd like, I can propose a short edited PR title and a ready-to-paste Impact of Change snippet to include in the PR body.


Last updated: Thu, 22 Jan 2026 02:22:00 GMT

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the ability to configure and add MCP (Model Context Protocol) servers for Standard SKU in the v2 designer. The implementation includes a new category for MCP servers, a browse view for selecting MCP servers, and a multi-step wizard for configuring connections and parameters before adding an MCP server to the workflow definition.

Changes:

  • Added MCP wizard state management with Redux (slice, selectors, types)
  • Implemented MCP server browse view with filtering and sorting capabilities
  • Created connection configuration wizard with connection selection, creation, and parameter configuration steps
  • Integrated MCP servers into search functionality and operation discovery
  • Added comprehensive unit tests for new functionality

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
libs/logic-apps-shared/src/designer-client-services/lib/standard/connection.ts Enhanced MCP connection data conversion to include server URL and authentication
libs/logic-apps-shared/src/designer-client-services/lib/standard/__tests__/connection.spec.ts Added unit tests for MCP connection conversion logic
libs/designer-v2/src/lib/core/state/panel/panelTypes.ts Added MCP wizard state types and step constants
libs/designer-v2/src/lib/core/state/panel/panelSlice.ts Implemented MCP wizard state management actions
libs/designer-v2/src/lib/core/state/panel/panelSelectors.ts Added selectors for MCP wizard state
libs/designer-v2/src/lib/core/queries/browse.ts Added query for fetching MCP servers
libs/designer-v2/src/lib/ui/panel/recommendation/browse/mcpToolWizard.tsx Implemented multi-step wizard for MCP tool configuration
libs/designer-v2/src/lib/ui/panel/recommendation/browse/mcpServersBrowse.tsx Created browse view for MCP servers with tabs and sorting
libs/designer-v2/src/lib/ui/panel/recommendation/helpers.ts Added helper functions for MCP operations
libs/designer-v2/src/lib/ui/panel/recommendation/searchView.tsx Integrated MCP servers into search results
libs/designer-v2/src/lib/ui/panel/recommendation/recommendationPanelContext.tsx Updated panel to support MCP wizard UI
Multiple test files Comprehensive unit test coverage for all new functionality
Localize/lang/strings.json Added localization strings for MCP features

@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

@anthony0t anthony0t added risk:medium Medium risk change with potential impact and removed risk:low Low risk change with minimal impact labels Jan 22, 2026
…__/mcpToolWizard.spec.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:medium Medium risk change with potential impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants