Skip to content

Conversation

@hartra344
Copy link
Collaborator

@hartra344 hartra344 commented Jan 13, 2026

Commit Type

  • feature - New functionality

Risk Level

  • Medium

What & Why

Add disclaimer for Independent Publisher connectors to comply with CELA legal requirements. When users create a connection to an Independent Publisher connector, they now see a warning and MIT License agreement matching the Power Platform experience.

This addresses compliance concerns raised in the email thread regarding Independent Publisher connectors needing explicit disclaimers and license agreement.

Impact of Change

  • Users: Users creating connections to Independent Publisher connectors will see a disclaimer warning about the risks and must agree to the MIT License
  • Developers: New isIndependentPublisherConnector helper function available in @microsoft/logic-apps-shared
  • System: No performance or architecture impact

Test Plan

  • Manual testing completed
  • Tested in: Standalone designer with Independent Publisher connectors

Contributors

@rarayudu @haroldcampos

Screenshots/Videos

The disclaimer appears as a styled container with:

  • Blue left border and light background
  • Warning text about Independent Publisher connectors being provided "as is"
  • Link to certification documentation
  • MIT License agreement text with bold button name

Layout matches the Power Platform example provided in the compliance email.

Add disclaimer for Independent Publisher connectors to comply with legal
requirements. When users create a connection to an Independent Publisher
connector, they now see:

- Warning about connectors being provided 'as is' without warranty
- Notice that connectors are not supported by Microsoft
- Link to certification documentation
- MIT License agreement that users accept by clicking Create

This addresses CELA compliance requirements for Independent Publisher
connectors to match the Power Platform experience.

Changes:
- Add isIndependentPublisherConnector helper to detect IP connectors
- Add IndependentPublisherDisclaimer component with styled warning
- Integrate disclaimer into CreateConnection component
- Add new i18n strings for disclaimer text
Copilot AI review requested due to automatic review settings January 13, 2026 19:22
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: feat(designer): Add Independent Publisher connector disclaimer
  • Issue: None — title is clear, follows conventional commit-style prefix and describes the change and scope.
  • Recommendation: Keep as-is. (Optional: if you want to be even more explicit you could include the target UX surface, e.g. feat(designer/connections): Add Independent Publisher connector disclaimer, but current title is fine.)

Commit Type

  • Properly selected (feature)
  • Only one commit type is selected which is correct for this change.

Risk Level

  • The PR body marks the change as Medium and the repository has the risk:medium label.
  • Assessment: the advised risk level based on the diff is also Medium. The change touches UI, localization strings, and a shared helper used to identify Independent Publisher connectors — a moderate-scope change with user-visible behavior and detection heuristics, so Medium is appropriate.

What & Why

  • Current: "Add disclaimer for Independent Publisher connectors to comply with CELA legal requirements..." (full paragraph present in PR body)
  • Issue: None — the description is concise and explains the reason (compliance) and what changed.
  • Recommendation: Consider adding a link or reference to the compliance ticket/email (if internal), e.g. "See CELA email thread X" or ticket ID, for easier future traceability.

⚠️ Impact of Change

  • The Impact section is present and reasonably detailed.
  • Issue: Suggest small clarifications:
    • The PR notes a new helper in @microsoft/logic-apps-shared — call out any consumers/side effects if other code paths will rely on that helper. If this helper will be used by other code paths, consider adding unit tests for it (see Test Plan below).
    • The change is user-visible (UI disclaimer) and adds localization strings; remind that localized strings need to be propagated to translations processes if applicable.
  • Recommendation:
    • Users: Users creating connections to Independent Publisher connectors will see a disclaimer and must acknowledge license language.
    • Developers: New helper isIndependentPublisherConnector added; consider adding unit tests to validate its heuristic and documenting the exact detection criteria.
    • System: No perf/arch changes expected; confirm that adding the new shared helper doesn't affect build tree-shaking or packaging.

⚠️ Test Plan

  • Current selection: Manual testing completed (tested in Standalone designer)

  • Assessment: Manual testing explanation is present and acceptable for a UI-only change.

  • Issue / Recommendation: Please add unit tests for the new detection logic and a simple component test for the disclaimer UI. Specific suggestions:

    • Add unit tests for isIndependentPublisherConnector (libs/logic-apps-shared) to verify behavior for: display name containing (Independent Publisher), connector id/name ending in ip, and negative cases to avoid false positives.
    • Add a snapshot/render test for IndependentPublisherDisclaimer to ensure the component renders the expected localized text and links.
    • If adding tests is not feasible in this PR, add a short rationale in the Test Plan explaining why manual testing alone suffices and create a follow-up ticket to add the unit/E2E tests.

    Without unit tests for detection, there is a risk of future regressions or false positives/negatives from the heuristic.


⚠️ Contributors

  • Current: @rarayudu @haroldcampos listed
  • Assessment: Good — contributors are credited.
  • Recommendation: None required. (If others contributed informally, consider adding them.)

⚠️ Screenshots/Videos

  • Current: textual description provided (blue left border, warning text, links, MIT license agreement text)
  • Assessment: There's a UI/visual change. While an image isn't strictly required, a screenshot would make visual review faster for maintainers.
  • Recommendation: Add a screenshot of the disclaimer in the Standalone designer (one image) to the PR description if possible.

Summary Table

Section Status Recommendation
Title Keep as-is (optionally scope to connections)
Commit Type None
Risk Level Matches label; Medium is appropriate
What & Why Add link/reference to compliance ticket/email
Impact of Change ⚠️ Call out consumers of new helper and localization propagation; document if needed
Test Plan ⚠️ Add unit tests for helper and component or justify in body and create follow-up ticket
Contributors None
Screenshots/Videos ⚠️ Add at least one screenshot of the UI

Final message
Please add unit tests for the new helper isIndependentPublisherConnector and a simple test for the disclaimer component (or add a follow-up ticket and note it in Test Plan). Add a screenshot of the rendered disclaimer in the PR description if possible. If you intentionally left unit tests out, include a brief rationale and link to a follow-up issue so reviewers can track that work. Also consider adding an internal reference to the compliance email/ticket in the What & Why section for traceability. Once tests (or a documented follow-up) and a screenshot are added, you can remove the needs-pr-update label and this PR should be ready to merge. Thank you for the clear PR and good descriptions!


Last updated: Tue, 20 Jan 2026 23:30:45 GMT

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a legally required disclaimer for Independent Publisher connectors to comply with CELA requirements. When users create a connection to an Independent Publisher connector, they now see a warning about potential security/privacy risks and an MIT License agreement, matching the Power Platform experience.

Changes:

  • Added isIndependentPublisherConnector helper function to detect Independent Publisher connectors by display name or ID suffix pattern
  • Created new IndependentPublisherDisclaimer component that displays the warning and MIT License agreement
  • Integrated the disclaimer into the connection creation flow, displayed before action buttons
  • Added localization strings for the disclaimer text in multiple languages

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
libs/logic-apps-shared/src/utils/src/lib/helpers/connectors.ts Added isIndependentPublisherConnector function to detect Independent Publisher connectors by display name or ID suffix; includes code formatting updates to match project style
libs/designer/src/lib/ui/panel/connectionsPanel/createConnection/independentPublisherDisclaimer.tsx New component that displays the disclaimer warning and MIT License agreement with proper styling
libs/designer/src/lib/ui/panel/connectionsPanel/createConnection/createConnection.tsx Integrated the disclaimer component and imported the detection function; mostly formatting changes from code style enforcement
Localize/lang/strings.json Added four new localization strings for disclaimer text, learn more link, and license agreement text

@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

@hartra344 hartra344 added the risk:medium Medium risk change with potential impact label Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:medium Medium risk change with potential impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants