Componentry: remove Jetpack color overrides on core components by simison · Pull Request #47317 · Automattic/jetpack

simison · 2026-02-25T12:42:38Z

Spin-off from #47056

Jetpack components mostly rely on core components under the hood, with added features and style overrides on spacing/colors.

This PR focuses on removing color overrides everywhere where we used core components under the hood. I'll do functional changes and straight component-replacements in separate PR so that this can be tested easier.

Proposed changes:

Removes --wp-admin-theme-color* style overrides on componentry.
Remove unused --jp-highlight CSS variable.
Does not touch couple of files to keep this PR simpler, as I wasn't sure what these plugins/packages do:
- projects/packages/masterbar/src/admin-color-schemes/colors/_gutenberg.scss
- projects/plugins/inspect/app-ui/css/main/wp-admin.scss

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Go through different pages in Jetpack main plugin and individual plugins for Social, Boost, VideoPress and Protect.
Search & Boots dashboards had the most significant CSS removals, so those need testing thoroughly.
Pay attention especially to toggle, button and input componentry. Note hover/focus colors.

Changelog

Generate changelog entries for this PR (using AI).

github-actions · 2026-02-25T12:43:34Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/jp-components-core-colors branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/jp-components-core-colors

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/jp-components-core-colors

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2026-02-25T12:43:50Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copilot

Pull request overview

This pull request removes Jetpack color overrides on core WordPress components across multiple plugins and packages, allowing components to use default WordPress core styling. This is part of a larger effort (spin-off from PR #47056) to reduce custom styling and improve consistency with WordPress core.

Changes:

Removed --wp-admin-theme-color* CSS custom property overrides from multiple plugin and package stylesheets
Removed custom toggle styling to rely on WordPress core toggle components
Removed custom button styling including border-radius overrides and secondary button styles
Removed unused --jp-highlight CSS variable from root variables

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
projects/plugins/protect/src/js/styles.module.scss	Removed color theme overrides and focus border width customization
projects/plugins/boost/app/assets/src/css/main/wp-admin.scss	Removed color theme overrides and secondary button styling (has issue with remaining variable reference)
projects/plugins/boost/app/assets/src/css/admin-banner.scss	Removed custom CTA button styling (background, border, color, hover, focus states)
projects/packages/videopress/src/client/admin/components/video-thumbnail/style.module.scss	Removed spinner color override
projects/packages/search/src/dashboard/components/module-control/style.scss	Removed custom toggle styling and related variables
projects/packages/publicize/_inc/components/admin-page/toggles/styles.module.scss	Removed toggle color override
projects/packages/publicize/_inc/components/admin-page/toggles/social-notes-toggle/styles.module.scss	Removed toggle color override
projects/packages/my-jetpack/_inc/style.module.scss	Removed color theme overrides
projects/js-packages/components/components/toggle-control/styles.module.scss	Removed toggle color override
projects/js-packages/components/components/button/style.module.scss	Removed color theme overrides and border-radius customization
projects/js-packages/base-styles/root-variables.scss	Removed unused `--jp-highlight` variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-25T12:47:03Z

projects/plugins/boost/app/assets/src/css/main/wp-admin.scss

@@ -11,11 +11,6 @@ p {
 }
 // Override WordPress component styles
 .jb-dashboard {


The custom override for --wp-admin-theme-link-color has been removed, but this variable is still referenced on lines 36 and 40 of this file. Since the custom override was #{variables.$gray_90}, removing it means these elements will now use WordPress core's default link color instead of the previous gray color. This could result in a visual change. If this is intentional, the references should ideally be updated to either use the core variable directly or be removed if the default behavior is desired.

They might still be needed, but needs a closer look:

jetpack/projects/plugins/boost/app/assets/src/css/main/wp-admin.scss

Lines 40 to 46 in 83e5487

a {

color: var(--wp-admin-theme-link-color);

}

.components-button.is-link:not(:disabled) {

color: var(--wp-admin-theme-link-color);

}

These also are related and need a closer look to see what they actually affect:

jetpack/projects/plugins/boost/app/assets/src/css/main/wp-admin.scss

Lines 96 to 105 in 83e5487

// Override WP styles for panel header.

.components-panel__body-title .components-button:hover:not(:disabled,[aria-disabled="true"]),

.components-panel__body-title .components-button[aria-expanded="true"] {

color: inherit;

}

.components-panel__body-toggle.components-button:focus {

border-radius: inherit;

box-shadow: none;

}

jp-launch-control · 2026-02-25T13:03:43Z

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

simison · 2026-02-25T13:22:59Z

projects/plugins/boost/app/assets/src/css/main/wp-admin.scss

-		color: variables.$primary-black;
-		background: none;
-		border: 1px solid variables.$primary-black;
-		padding: 8px 24px;
-		border-radius: 3px;
-		font-weight: 600;
-		cursor: pointer;
-		font-size: 16px;
-		line-height: 24px;


Some non-color changes here so need to double check where it was applied in Boost and check properly.

Componentry: remove Jetpack color overrides on core components

1cbeb6b

Copilot AI review requested due to automatic review settings February 25, 2026 12:42

simison added [Status] Needs Review This PR is ready for review. [JS Package] Components labels Feb 25, 2026

Copilot started reviewing on behalf of simison February 25, 2026 12:43 View session

github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Feb 25, 2026

Add changelog entries.

d6b9934

Copilot AI reviewed Feb 25, 2026

View reviewed changes

simison added [Status] In Progress and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Feb 25, 2026

simison commented Feb 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Componentry: remove Jetpack color overrides on core components#47317

Componentry: remove Jetpack color overrides on core components#47317
simison wants to merge 2 commits intotrunkfrom
update/jp-components-core-colors

simison commented Feb 25, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 25, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 25, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

simison Feb 25, 2026

Uh oh!

jp-launch-control bot commented Feb 25, 2026

Uh oh!

simison Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	a {
	color: var(--wp-admin-theme-link-color);
	}

	.components-button.is-link:not(:disabled) {
	color: var(--wp-admin-theme-link-color);
	}

	// Override WP styles for panel header.
	.components-panel__body-title .components-button:hover:not(:disabled,[aria-disabled="true"]),
	.components-panel__body-title .components-button[aria-expanded="true"] {
	color: inherit;
	}

	.components-panel__body-toggle.components-button:focus {
	border-radius: inherit;
	box-shadow: none;
	}

Comments

Conversation

simison commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Changelog

Uh oh!

github-actions bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

simison Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

jp-launch-control bot commented Feb 25, 2026

Code Coverage Summary

Uh oh!

simison Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

simison commented Feb 25, 2026 •

edited

Loading

github-actions bot commented Feb 25, 2026 •

edited

Loading

github-actions bot commented Feb 25, 2026 •

edited

Loading