Subscription Block: only add excerpt link to Newsletters#47311
Subscription Block: only add excerpt link to Newsletters#47311arcangelini merged 6 commits intotrunkfrom
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
There was a problem hiding this comment.
Pull request overview
This PR removes the Subscriptions block’s global excerpt mutation that appended a “View post … subscribe” message, preventing that text from being injected into excerpts (including newsletter excerpt emails), and records the fix in the Jetpack changelog.
Changes:
- Removed the
get_the_excerptfilter hook that appended newsletter subscription messaging when a post contained the Subscriptions block. - Deleted the now-unused
jetpack_filter_excerpt_for_newsletter()function. - Added a changelog entry documenting the bugfix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| projects/plugins/jetpack/extensions/blocks/subscriptions/subscriptions.php | Removes the excerpt filter + helper that appended the “View post … subscribe” message. |
| projects/plugins/jetpack/changelog/fix-subscription-block-excerpt-text | Adds a patch-level changelog note for the behavior change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
projects/plugins/jetpack/extensions/blocks/subscriptions/subscriptions.php
Show resolved
Hide resolved
projects/plugins/jetpack/changelog/fix-subscription-block-excerpt-text
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes https://linear.app/a8c/issue/NL-470/only-append-subscribe-message-in-newsletter-email-render
Proposed changes:
Remove the
jetpack_filter_excerpt_for_newslettermethod from the excerpt filter and delete the method.Other information:
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Excerpt.View post to subscribe to site newsletter.is gone