Image Studio: Feature parity with Big Sky#47138
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryCoverage changed in 1 file.
|
Edit with AI media row button)4534c84 to
b895797
Compare
cebafd0 to
c1720cc
Compare
2bb3bb4 to
3eb5e87
Compare
e532dea to
5fc64e6
Compare
3eb5e87 to
49ff429
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds feature parity with "Big Sky" by introducing an "Edit with AI" row action in the Media Library and simplifying the AI extension disabling logic. The changes make Image Studio globally disable conflicting AI extensions when available, rather than checking screen context.
Changes:
- Added "Edit with AI" row action in Media Library list view for supported image types (JPEG, JPG, PNG, WebP, BMP, TIFF)
- Simplified AI extension disabling to check feature availability globally instead of per-screen
- Updated tests to reflect the new behavior with proper
register_plugin()calls
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| projects/plugins/jetpack/extensions/plugins/image-studio/image-studio.php | Adds row action functions and simplifies AI extension disabling logic to check global feature availability |
| projects/plugins/jetpack/tests/php/extensions/plugins/image-studio/Image_Studio_Test.php | Updates existing tests with register_plugin() calls and adds comprehensive row action test coverage |
| projects/plugins/jetpack/changelog/forno-194-image-studio-feature-parity | Documents the enhancement with appropriate significance and type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
projects/plugins/jetpack/extensions/plugins/image-studio/image-studio.php
Outdated
Show resolved
Hide resolved
projects/plugins/jetpack/tests/php/extensions/plugins/image-studio/Image_Studio_Test.php
Show resolved
Hide resolved
4caa235 to
34bdedf
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
projects/plugins/jetpack/extensions/plugins/image-studio/image-studio.php
Show resolved
Hide resolved
projects/plugins/jetpack/extensions/plugins/image-studio/image-studio.php
Show resolved
Hide resolved
projects/plugins/jetpack/extensions/plugins/image-studio/image-studio.php
Show resolved
Hide resolved
projects/plugins/jetpack/extensions/plugins/image-studio/image-studio.php
Outdated
Show resolved
Hide resolved
projects/plugins/jetpack/tests/php/extensions/plugins/image-studio/Image_Studio_Test.php
Show resolved
Hide resolved
projects/plugins/jetpack/extensions/plugins/image-studio/image-studio.php
Show resolved
Hide resolved
projects/plugins/jetpack/extensions/plugins/image-studio/image-studio.php
Show resolved
Hide resolved
The block editor and media library screen tests were missing the register_plugin() call, so the feature was never marked available and disable_jetpack_ai_image_extensions() bailed out early.
87bc39a to
7aa4c76
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
projects/plugins/jetpack/tests/php/extensions/plugins/image-studio/Image_Studio_Test.php
Show resolved
Hide resolved
|
@kat3samsin I've opened a new pull request, #47320, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Add test cases for image/jpg, image/bmp, and image/tiff MIME types Co-authored-by: kat3samsin <2224344+kat3samsin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kat3samsin <2224344+kat3samsin@users.noreply.github.com>
Fixes #
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: