This repository was archived by the owner on Sep 5, 2025. It is now read-only.
Improved the category output on posts#1460
Open
ndiego wants to merge 1 commit intoAutomattic:masterfrom
ndiego:improve-post-category-output
Open
Improved the category output on posts#1460ndiego wants to merge 1 commit intoAutomattic:masterfrom ndiego:improve-post-category-output
ndiego wants to merge 1 commit intoAutomattic:masterfrom
ndiego:improve-post-category-output
Conversation
When a post had no category assigned, the _s_entry_footer() function would still output "Posted on Uncategorized". This commit fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a post has no category assigned to it, not even the default Uncategorized category that WordPress assigns, the
_s_entry_footer()function still outputs "Posted on Uncategorized". This PR fixes that.It appears as if this function was intended to display nothing when a post has no categories since it is checking if
$categories_listexists. The problem is this variable is set to "Uncategorized" by default if the post has no categories assigned. In this PR, we are simply adding thehas_category()check to the conditional. Then, when a post has no categories, nothing is displayed as expected!