Skip to content
This repository was archived by the owner on Sep 5, 2025. It is now read-only.

Comments

Remove removed PHPCS rule#1374

Closed
szepeviktor wants to merge 1 commit intoAutomattic:masterfrom
szepeviktor:patch-2
Closed

Remove removed PHPCS rule#1374
szepeviktor wants to merge 1 commit intoAutomattic:masterfrom
szepeviktor:patch-2

Conversation

@szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Sep 17, 2019

@szepeviktor szepeviktor changed the title Removed removed PHPCS rule Remove removed PHPCS rule Sep 17, 2019
@szepeviktor
Copy link
Contributor Author

much better: https://travis-ci.org/Automattic/_s/jobs/586252288#L620-L663
now there are only small style errors

@szepeviktor
Copy link
Contributor Author

@crunnells Automattic decided to halt _s developement?

@jrfnl
Copy link
Contributor

jrfnl commented Sep 17, 2019

@szepeviktor Please see #1311

Regarding the specific sniff: the sniff has not been removed, but has been renamed. Though instead of updating the name in the ruleset, it would be better to switch to PHPCompatibilityWP instead (which is what is done in #1311, though that PR is very out of date and I have little motivation to update it as PRs in this repo are being left to rot instead of being merged).

@Ismail-elkorchi
Copy link
Contributor

@szepeviktor Thank you for the PR and for your willingness to contribute to this project. As Juliette said, the changes regarding this sniff must be done in #1311. So I'm going to close this PR.

@jrfnl If you have the time, the motivation and the energy to update #1311, I'd be willing to review it and then merge it promptly.

@szepeviktor szepeviktor deleted the patch-2 branch March 23, 2020 14:19
@szepeviktor
Copy link
Contributor Author

Thank you.

@jrfnl
Copy link
Contributor

jrfnl commented Mar 23, 2020

@Ismail-elkorchi Working on WPCS 3.0 for the moment, let's update that PR after the that's done so it is ready for the future.

@Ismail-elkorchi
Copy link
Contributor

@jrfnl That's really awesome. Thank you for your great work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants