This repository was archived by the owner on Sep 5, 2025. It is now read-only.
chore(phpcs): Fix compatibility with PHPCompatibility 9.0#1324
Closed
mirucon wants to merge 1 commit intoAutomattic:masterfrom
mirucon:fix/phpcompatibility
Closed
chore(phpcs): Fix compatibility with PHPCompatibility 9.0#1324mirucon wants to merge 1 commit intoAutomattic:masterfrom mirucon:fix/phpcompatibility
mirucon wants to merge 1 commit intoAutomattic:masterfrom
mirucon:fix/phpcompatibility
Conversation
Since the PHPCompatibility version 9, the sniff PHP.RemovedExtensions has been renamed to Extensions.RemovedExtensions. This commit renames it to the new name, so that the PHPCS works now correctly.
|
This PR looks to solve a genuine problem with the current build. As it's now closed, would the maintainers be open to a new PR to fix this? Alternatively, could this PR be merged? This build log shows the failure that this PR would fix. This changelog explains the renaming that's required, and done in this PR. |
Author
|
@mirucon Thanks, I missed that PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the PHPCompatibility version 9, the sniff PHP.RemovedExtensions has been renamed to Extensions.RemovedExtensions.
This commit renames it to the new name so that the PHPCS works now correctly.
https://github.com/PHPCompatibility/PHPCompatibility/releases/tag/9.0.0