Add basic composer.json file.#1297
Conversation
|
Thank you @alexmacarthur for the PR. We were discussing in #1291 about adding a There are three main groups of uses for
The One question on my mind is:
I see two options.
I don't think we should include the |
|
Thanks for the feedback, @grappler. Agreed, the value for something like this would be found by people using Composer in their development, and I don't think it'd be worth including in the underscores.me generator. Would there be any harm in including the file in the repo anyway, and then having people do what they want with it after that? And if there is harm, would the value outweigh that harm? I'm obviously partial to having a Composer file included in the repo itself, but I'm also not aware of the scope of what it might impact. |
|
I would consider adding the file, and changing the package type to Otherwise I would add the composer installers package as a dependency |
|
@alexmacarthur Thank you for the Pull Request. Closing as |
Changes proposed in this Pull Request:
I'd be helpful to be able to require the _s theme via Composer using the Composer Installers package, which would automatically place the
wordpress-themetype in the specified themes directory.An example of how someone might leverage this Composer file can be seen here:
https://github.com/alexmacarthur/wp-skateboard/tree/starter-theme-underscores
As a solution to all of this, I've created a very basic
composer.jsonfile. It can certainly be improved, but contains all the essential information as a starting point.