This repository was archived by the owner on Sep 5, 2025. It is now read-only.
Prevent variables comments showing in the production file#1237
Closed
gasatrya wants to merge 11 commits intoAutomattic:masterfrom
gasatrya:master
Closed
Prevent variables comments showing in the production file#1237gasatrya wants to merge 11 commits intoAutomattic:masterfrom gasatrya:master
gasatrya wants to merge 11 commits intoAutomattic:masterfrom
gasatrya:master
Conversation
Contributor
|
Thank you @Satrya Do you think it would make sense to change the other titles too in |
Contributor
|
Let's hold this PR for a while. We have lot's of SASS/CSS related tickets coming up which we need to look first. |
…markup, to improve accessibility.
Contributor
|
Closing as this was fixed in #1391. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variables comments do not need to show up in the production file.