Changed get_template_directory_uri function with get_theme_file_uri#1142
Changed get_template_directory_uri function with get_theme_file_uri#1142vinoddalvi wants to merge 2 commits intoAutomattic:masterfrom
Conversation
|
Hi @vinoddalvi! Thank you for the pull request! In the future, please try to include some kind of description with pull requests. Even simple things. It makes it easier for maintainers to review issues and PRs in order to make decision. I'd also say that a well written issue or PR description is just as valuable as code – sometimes more so. 😄 That said, with this feature having launched in 4.7, we should probably wait until 4.9 comes out or do some kind of check to fall back if the function isn't available. Historically, we've tried to support WordPress versions two versions back from the current one in _s. We should also think about the |
|
@davidakennedy Thank you for your kind reply and sure i will add description in the PR henceforward. |
|
Will this change be implemented in the code? |
No description provided.