-
Notifications
You must be signed in to change notification settings - Fork 0
Update to Ubuntu 24.04 with GCC 13 and clang 16 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Feel free to move clang to a bit higher version than 14 (which is already 3 1/2 years old) |
|
Also Ubuntu 24.04 is the latest LTS version, so likely better to move to that one 😉 |
|
I was trying to keep versions as low as possible to allow wider support for older systems. But maybe we can be more daring 😅 |
|
Usually, we set the Docker images to the highest compiler versions that are available on all super computers we used regularly. |
Hmm, HSUper doesn't have clang at all and on cool/supermuc they've just updated the software, so that would be clang-21 :D I at least bumped it up to 15 now, as this corresponds to the apple clang version we test and it seems to have less hiccups with OMP than clang-14. |
|
Had a brief talk with @schuhmaj and we decided to upgrade to Ubuntu 24 as suggested. This gives us gcc 13, which is the version available on HSUper. Clang is updated to version 16, as its release was around the same time as gcc 13. |
|
Drop us a message when the repo is ready to review again |
|
@SamNewcome It is now in conjunction with AutoPas/AutoPas#1051 |
schuhmaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; I would approve 👍 as is. However, one question:
Why are we building OpenMP from source and don't install it via apt. Is there a similiar issue like with MPI?
| ENV CLANGVERSION=16 | ||
|
|
||
| # add llvm repository (needed for newer versions of clang) | ||
| # Add llvm repository (can be used to get newer versions of clang) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Add llvm repository (can be used to get newer versions of clang) | |
| # If needed in future: add llvm repository (can be used to get newer versions of clang) |
| ENV CLANGVERSION=16 | ||
|
|
||
| # add llvm repository (needed for newer clang versions) | ||
| # Add llvm repository (can be used to get newer clang versions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Add llvm repository (can be used to get newer clang versions) | |
| # If needed in future: add llvm repository (can be used to get newer clang versions) |
I had issues with clang not being able to compile the C++ feature "ranges".
After fumbling around with the clang Dockerfile for a while, I figured that upgrading the base image is the simplest solution and about time as well.