Skip to content

Conversation

@thesamriel
Copy link
Member

I had issues with clang not being able to compile the C++ feature "ranges".
After fumbling around with the clang Dockerfile for a while, I figured that upgrading the base image is the simplest solution and about time as well.

@SteffenSeckler
Copy link
Member

SteffenSeckler commented Nov 27, 2025

Feel free to move clang to a bit higher version than 14 (which is already 3 1/2 years old)

@SteffenSeckler
Copy link
Member

Also Ubuntu 24.04 is the latest LTS version, so likely better to move to that one 😉

@thesamriel
Copy link
Member Author

I was trying to keep versions as low as possible to allow wider support for older systems. But maybe we can be more daring 😅

@FG-TUM
Copy link
Member

FG-TUM commented Nov 27, 2025

Usually, we set the Docker images to the highest compiler versions that are available on all super computers we used regularly.

@thesamriel thesamriel changed the title Ubuntu to 22.04 and Clang to 14 Ubuntu to 22.04 and Clang to 15 Nov 27, 2025
@thesamriel
Copy link
Member Author

Usually, we set the Docker images to the highest compiler versions that are available on all super computers we used regularly.

Hmm, HSUper doesn't have clang at all and on cool/supermuc they've just updated the software, so that would be clang-21 :D

I at least bumped it up to 15 now, as this corresponds to the apple clang version we test and it seems to have less hiccups with OMP than clang-14.

@thesamriel thesamriel changed the title Ubuntu to 22.04 and Clang to 15 Update to Ubuntu 24.04 with GCC 13 and clang 16 Nov 28, 2025
@thesamriel
Copy link
Member Author

Had a brief talk with @schuhmaj and we decided to upgrade to Ubuntu 24 as suggested. This gives us gcc 13, which is the version available on HSUper. Clang is updated to version 16, as its release was around the same time as gcc 13.
I changed / updated some dependency installations as the Ubuntu 24 already provides recent versions for most things.

@SamNewcome
Copy link
Contributor

Drop us a message when the repo is ready to review again

@thesamriel
Copy link
Member Author

@SamNewcome It is now in conjunction with AutoPas/AutoPas#1051

Copy link

@schuhmaj schuhmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I would approve 👍 as is. However, one question:

Why are we building OpenMP from source and don't install it via apt. Is there a similiar issue like with MPI?

@thesamriel thesamriel requested a review from SamNewcome December 3, 2025 16:04
ENV CLANGVERSION=16

# add llvm repository (needed for newer versions of clang)
# Add llvm repository (can be used to get newer versions of clang)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Add llvm repository (can be used to get newer versions of clang)
# If needed in future: add llvm repository (can be used to get newer versions of clang)

ENV CLANGVERSION=16

# add llvm repository (needed for newer clang versions)
# Add llvm repository (can be used to get newer clang versions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Add llvm repository (can be used to get newer clang versions)
# If needed in future: add llvm repository (can be used to get newer clang versions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants