Open
Conversation
leniency
commented
Jun 18, 2019
leniency
commented
- Set projects to be netstandard instead of netcoreapp. This increases compatibility with full-framework projects.
- Exposed async query methods for controllers.
- Properly flagged the version as -beta
- Set it to be a netstandard library instead of a netcorapp - greater compatibility.
…h dotnet pack commands. nuspec file is not needed with this, but left file for reference. Upstream maintainers can remove later.
- Added a few simple unit tests
|
Why hasn't this been merged yet? :( |
Merge leniency/dotnet-core-sdk-beta changes into our repo
|
I can't understand why this hasn't been merged thus far. It looks like that the API has been abandoned :( @leniency thank you for taking the time! Their API wasn't working with .NET Core 3.0 but yours is. |
- Updated test dependencies.
|
Appreciate the work. It would be great if this would get merged and released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.