Skip to content

Comments

Add support for reading from OBS Studio#65

Open
kamperemu wants to merge 40 commits intoAuroraWright:masterfrom
kamperemu:obs_patch
Open

Add support for reading from OBS Studio#65
kamperemu wants to merge 40 commits intoAuroraWright:masterfrom
kamperemu:obs_patch

Conversation

@kamperemu
Copy link

Closes #61

Tested on Windows and Linux.
I've also added some configuration options (although I'm not completely sure if some of them are even needed).

I'd like to mention that it is possible to make the obs thread keep trying to reconnect if connection is lost but it currently just stops owocr if it disconnects.

@kamperemu
Copy link
Author

Also I don't know why but github is showing diffs where lines haven't been changed. This also seems to be a quirk of this commit 0aa11cc.

@bpwhelan
Copy link
Collaborator

bpwhelan commented Feb 1, 2026

Just some comments since I assume this is inspired by GSM. I can review this if desired (after line endings fix), but just some initial thoughts.

  • Lossless PNG being default will lead to a very bad experience for many people who try this. I've gone down that road before, and it's really awfully slow compared to a good quality jpeg.
  • Should clamp scaling for many reasons
  1. Giving OBS w/h bigger than the source's dimensions probably does nothing.
  2. Super low scaling will completely break OCR
  3. Weird scaling numbers could lead to soft images, negatively impacting performance and ocr results.
  • Could add an option to capture the preview instead, or even make it default? Not a good fit for GSM but could definitely fit and make sense in owocr.

@kamperemu kamperemu marked this pull request as draft February 1, 2026 19:23
@kamperemu
Copy link
Author

kamperemu commented Feb 1, 2026

@bpwhelan Thanks for the feedback. Yes, this is inspired by GSM. I'd really appreciate a review (after I fix the line endings of course).

@AuroraWright AuroraWright force-pushed the master branch 4 times, most recently from 69bb249 to 788f967 Compare February 2, 2026 20:16
@AuroraWright AuroraWright force-pushed the master branch 13 times, most recently from de19ad4 to 44e712d Compare February 3, 2026 06:33
@AuroraWright AuroraWright force-pushed the master branch 16 times, most recently from 19c7a4d to 2f4f508 Compare February 5, 2026 05:38
@AuroraWright AuroraWright force-pushed the master branch 6 times, most recently from 9c1addd to 3cd51e8 Compare February 20, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] read from OBS Studio

3 participants