Add support for reading from OBS Studio#65
Open
kamperemu wants to merge 40 commits intoAuroraWright:masterfrom
Open
Add support for reading from OBS Studio#65kamperemu wants to merge 40 commits intoAuroraWright:masterfrom
kamperemu wants to merge 40 commits intoAuroraWright:masterfrom
Conversation
Author
|
Also I don't know why but github is showing diffs where lines haven't been changed. This also seems to be a quirk of this commit 0aa11cc. |
Collaborator
|
Just some comments since I assume this is inspired by GSM. I can review this if desired (after line endings fix), but just some initial thoughts.
|
Author
|
@bpwhelan Thanks for the feedback. Yes, this is inspired by GSM. I'd really appreciate a review (after I fix the line endings of course). |
69bb249 to
788f967
Compare
de19ad4 to
44e712d
Compare
Co-authored-by: Beangate <bpwhelan95@gmail.com>
19c7a4d to
2f4f508
Compare
9c1addd to
3cd51e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #61
Tested on Windows and Linux.
I've also added some configuration options (although I'm not completely sure if some of them are even needed).
I'd like to mention that it is possible to make the obs thread keep trying to reconnect if connection is lost but it currently just stops owocr if it disconnects.