Skip to content

Conversation

@Tel0k
Copy link

@Tel0k Tel0k commented Sep 16, 2024

No description provided.

@Tel0k
Copy link
Author

Tel0k commented Oct 24, 2024

Resolves #258

@kgirtxd kgirtxd linked an issue Oct 24, 2024 that may be closed by this pull request
added missing flavor text, feature replacements and other small fixes
@tregolani
Copy link

tregolani commented Oct 31, 2024

Seeing how I'll be updating my PR with some changes, should we update the "ASI" grants to be pointing towards feats instead (since ASIs are a type of feat now)?

<grant type="Class Feature" id="ID_WOTC_PHB24_CLASS_FEATURE_RANGER_ASI" level="4"/>

should become

<grant type="Class Feature" id="ID_WOTC_PHB24_CLASS_FEATURE_RANGER_FEAT" level="4"/>

@NickVendel
Copy link
Contributor

targeting feats would be type="Feat", and yeah, i think that's the way we gonna do it now.

@tregolani
Copy link

tregolani commented Oct 31, 2024

targeting feats would be type="Feat", and yeah, i think that's the way we gonna do it now.

These are the IDs for the class feature that grants feats. We'd have a <rules> tag inside this element that would then grant the Feats.

I'm mostly just trying to nail down "ID naming conventions" for my PR edit later this weekend.

@NickVendel
Copy link
Contributor

NickVendel commented Oct 31, 2024

but why? If all they do is grant Feats, why not just grant Feats right away?

@tregolani
Copy link

We need the "Class Feature" element so it shows up in the feature list of the class, just like Epic Boons.

@NickVendel
Copy link
Contributor

ah, yeah, then it should still be _CLASS_FEATURE_ just because it's that type.

@Tel0k
Copy link
Author

Tel0k commented Oct 31, 2024

tbh then they should be selections, not grants.. remember that the feature let you choose between ASI or another Feat for which you qualify.. same thing with Epic Boons..

@tregolani
Copy link

Right. We still need the "class feature" element so they show up in the list of class features. We then do a select in the rules of that class feature element to allow the user to pick their feat.

I mostly was asking to change the ID of the "class feature" element to _FEAT instead of _ASI, but in the books it's still called "Ability Score Improvement", so I think my point was moot. We should keep the class feature ID as _ASI.

@NickVendel
Copy link
Contributor

full name would probably be more appropriate, but i won't argue with an abbreviation either

@tregolani
Copy link

Well, what's the standard naming convention we want to go with, moving forward? ASI or ABILITYSCOREIMPROVEMENT?

@Tel0k Tel0k changed the title [PHB24] Ranger Class + Subclasses [PHB24] Ranger & Paladin Classes + Subclasses Nov 3, 2024
@Tel0k
Copy link
Author

Tel0k commented Nov 3, 2024

Resolves #257

Copy link

@tregolani tregolani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all files both in app and via code. Made suggestions where I thought appropriate. Most were styling changes or typo fixes.

Tel0k and others added 3 commits November 21, 2024 17:00
Copy link

@tregolani tregolani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small corrections based on my week of testing in the app. Mostly just small spelling corrections.

Copy link
Contributor

@NickVendel NickVendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go. I hope i didn't miss any changes i made in my files.

<h5>CORE PALADIN TRAITS</h5>
<table>
<tr><td><b>Primary Ability</b></td><td>Strength and Charisma</td></tr>
<tr><td><b>Hit Point Die</b></td><td>1d10 per Paladin level</td></tr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<tr><td><b>Hit Point Die</b></td><td>1d10 per Paladin level</td></tr>
<tr><td><b>Hit Point Die</b></td><td>D10 per Paladin level</td></tr>

<h5 style="margin-top: 0px">AS A MULTICLASS CHARACTER</h5>
<ul style="margin-top:-1em">
<li>Gain the following traits from the Core Paladin Traits table: Hit Point Die, proficiency with Martial weapons, and training with Light and Medium armor and Shields.</li>
<li>Gain the Paladin's level 1 features, which are listed in the Paladin Features table. See the multiclassing rules in chapter 2 to determine your available spell slots.</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>Gain the Paladin's level 1 features, which are listed in the Paladin Features table. See the multiclassing rules in chapter 2 to determine your available spell slots.</li>
<li>Gain the Paladin's level 1 features, which are listed in the Paladin Features table.</li>

<li>Gain the following traits from the Core Paladin Traits table: Hit Point Die, proficiency with Martial weapons, and training with Light and Medium armor and Shields.</li>
<li>Gain the Paladin's level 1 features, which are listed in the Paladin Features table. See the multiclassing rules in chapter 2 to determine your available spell slots.</li>
</ul>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Comment on lines 43 to 65
<thead>
<tr><td class="col-5">Level</td><td>Proficiency Bonus</td><td class="col-50 left">Class Features</td><td class="col-10">Channel Divinity</td><td class="col-10">Prepared Spells</td><td>1st</td><td>2nd</td><td>3rd</td><td>4th</td><td>5th</td></tr>
</thead>
<tr><td> 1st</td><td>2</td><td class="left">Lay On Hands, Spellcasting, Weapon Mastery</td><td>—</td><td>2</td><td>2</td><td>—</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 2nd</td><td>2</td><td class="left">Fighting Style, Paladin's Smite</td><td>—</td><td>3</td><td>2</td><td>—</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 3rd</td><td>2</td><td class="left">Channel Divinity, Paladin Subclass</td><td>2</td><td>4</td><td>3</td><td>—</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 4th</td><td>2</td><td class="left">Ability Score Improvement</td><td>2</td><td>5</td><td>3</td><td>—</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 5th</td><td>3</td><td class="left">Extra Attack, Faithful Steed</td><td>2</td><td>6</td><td>4</td><td>2</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 6th</td><td>3</td><td class="left">Aura of Protection</td><td>2</td><td>6</td><td>4</td><td>2</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 7th</td><td>3</td><td class="left">Subclass feature</td><td>2</td><td>7</td><td>4</td><td>3</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 8th</td><td>3</td><td class="left">Ability Score Improvement</td><td>2</td><td>7</td><td>4</td><td>3</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 9th</td><td>4</td><td class="left">Abjure Foes</td><td>2</td><td>9</td><td>4</td><td>3</td><td>2</td><td>—</td><td>—</td></tr>
<tr><td>10th</td><td>4</td><td class="left">Aura of Courage</td><td>2</td><td>9</td><td>4</td><td>3</td><td>2</td><td>—</td><td>—</td></tr>
<tr><td>11th</td><td>4</td><td class="left">Radiant Strikes</td><td>3</td><td>10</td><td>4</td><td>3</td><td>3</td><td>—</td><td>—</td></tr>
<tr><td>12th</td><td>4</td><td class="left">Ability Score Improvement</td><td>3</td><td>10</td><td>4</td><td>3</td><td>3</td><td>—</td><td>—</td></tr>
<tr><td>13th</td><td>5</td><td class="left">—</td><td>3</td><td>11</td><td>4</td><td>3</td><td>3</td><td>1</td><td>—</td></tr>
<tr><td>14th</td><td>5</td><td class="left">Restoring Touch</td><td>3</td><td>11</td><td>4</td><td>3</td><td>3</td><td>1</td><td>—</td></tr>
<tr><td>15th</td><td>5</td><td class="left">Subclass feature</td><td>3</td><td>12</td><td>4</td><td>3</td><td>3</td><td>2</td><td>—</td></tr>
<tr><td>16th</td><td>5</td><td class="left">Ability Score Improvement</td><td>3</td><td>12</td><td>4</td><td>3</td><td>3</td><td>2</td><td>—</td></tr>
<tr><td>17th</td><td>6</td><td class="left">—</td><td>3</td><td>14</td><td>4</td><td>3</td><td>3</td><td>3</td><td>1</td></tr>
<tr><td>18th</td><td>6</td><td class="left">Aura Expansion</td><td>3</td><td>14</td><td>4</td><td>3</td><td>3</td><td>3</td><td>1</td></tr>
<tr><td>19th</td><td>6</td><td class="left">Epic Boon</td><td>3</td><td>15</td><td>4</td><td>3</td><td>3</td><td>3</td><td>2</td></tr>
<tr><td>20th</td><td>6</td><td class="left">Subclass feature</td><td>3</td><td>15</td><td>4</td><td>3</td><td>3</td><td>3</td><td>2</td></tr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<thead>
<tr><td class="col-5">Level</td><td>Proficiency Bonus</td><td class="col-50 left">Class Features</td><td class="col-10">Channel Divinity</td><td class="col-10">Prepared Spells</td><td>1st</td><td>2nd</td><td>3rd</td><td>4th</td><td>5th</td></tr>
</thead>
<tr><td> 1st</td><td>2</td><td class="left">Lay On Hands, Spellcasting, Weapon Mastery</td><td>—</td><td>2</td><td>2</td><td>—</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 2nd</td><td>2</td><td class="left">Fighting Style, Paladin's Smite</td><td>—</td><td>3</td><td>2</td><td>—</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 3rd</td><td>2</td><td class="left">Channel Divinity, Paladin Subclass</td><td>2</td><td>4</td><td>3</td><td>—</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 4th</td><td>2</td><td class="left">Ability Score Improvement</td><td>2</td><td>5</td><td>3</td><td>—</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 5th</td><td>3</td><td class="left">Extra Attack, Faithful Steed</td><td>2</td><td>6</td><td>4</td><td>2</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 6th</td><td>3</td><td class="left">Aura of Protection</td><td>2</td><td>6</td><td>4</td><td>2</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 7th</td><td>3</td><td class="left">Subclass feature</td><td>2</td><td>7</td><td>4</td><td>3</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 8th</td><td>3</td><td class="left">Ability Score Improvement</td><td>2</td><td>7</td><td>4</td><td>3</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 9th</td><td>4</td><td class="left">Abjure Foes</td><td>2</td><td>9</td><td>4</td><td>3</td><td>2</td><td>—</td><td>—</td></tr>
<tr><td>10th</td><td>4</td><td class="left">Aura of Courage</td><td>2</td><td>9</td><td>4</td><td>3</td><td>2</td><td>—</td><td>—</td></tr>
<tr><td>11th</td><td>4</td><td class="left">Radiant Strikes</td><td>3</td><td>10</td><td>4</td><td>3</td><td>3</td><td>—</td><td>—</td></tr>
<tr><td>12th</td><td>4</td><td class="left">Ability Score Improvement</td><td>3</td><td>10</td><td>4</td><td>3</td><td>3</td><td>—</td><td>—</td></tr>
<tr><td>13th</td><td>5</td><td class="left">—</td><td>3</td><td>11</td><td>4</td><td>3</td><td>3</td><td>1</td><td>—</td></tr>
<tr><td>14th</td><td>5</td><td class="left">Restoring Touch</td><td>3</td><td>11</td><td>4</td><td>3</td><td>3</td><td>1</td><td>—</td></tr>
<tr><td>15th</td><td>5</td><td class="left">Subclass feature</td><td>3</td><td>12</td><td>4</td><td>3</td><td>3</td><td>2</td><td>—</td></tr>
<tr><td>16th</td><td>5</td><td class="left">Ability Score Improvement</td><td>3</td><td>12</td><td>4</td><td>3</td><td>3</td><td>2</td><td>—</td></tr>
<tr><td>17th</td><td>6</td><td class="left">—</td><td>3</td><td>14</td><td>4</td><td>3</td><td>3</td><td>3</td><td>1</td></tr>
<tr><td>18th</td><td>6</td><td class="left">Aura Expansion</td><td>3</td><td>14</td><td>4</td><td>3</td><td>3</td><td>3</td><td>1</td></tr>
<tr><td>19th</td><td>6</td><td class="left">Epic Boon</td><td>3</td><td>15</td><td>4</td><td>3</td><td>3</td><td>3</td><td>2</td></tr>
<tr><td>20th</td><td>6</td><td class="left">Subclass feature</td><td>3</td><td>15</td><td>4</td><td>3</td><td>3</td><td>3</td><td>2</td></tr>
<tr style="font-weight: bold">
<td rowspan="2">Level</td>
<td class="col-30 left" rowspan="2">Class Features</td>
<td rowspan="2">Channel<br />Divinity</td>
<td rowspan="2">Prepared<br />Spells</td>
<td colspan="5" style="vertical-align:bottom; border-bottom: 0px">Spell Slots per Spell Level</td>
</tr>
<tr style="font-weight: bold"><td>1</td><td>2</td><td>3</td><td>4</td><td>5</td></tr>
<tr><td> 1</td><td class="left">Lay On Hands, Spellcasting, Weapon Mastery</td><td>—</td><td>2</td><td>2</td><td>—</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 2</td><td class="left">Fighting Style, Paladin's Smite</td><td>—</td><td>3</td><td>2</td><td>—</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 3</td><td class="left">Channel Divinity, Paladin Subclass</td><td>2</td><td>4</td><td>3</td><td>—</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 4</td><td class="left">Ability Score Improvement</td><td>2</td><td>5</td><td>3</td><td>—</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 5</td><td class="left">Extra Attack, Faithful Steed</td><td>2</td><td>6</td><td>4</td><td>2</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 6</td><td class="left">Aura of Protection</td><td>2</td><td>6</td><td>4</td><td>2</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 7</td><td class="left">Subclass feature</td><td>2</td><td>7</td><td>4</td><td>3</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 8</td><td class="left">Ability Score Improvement</td><td>2</td><td>7</td><td>4</td><td>3</td><td>—</td><td>—</td><td>—</td></tr>
<tr><td> 9</td><td class="left">Abjure Foes</td><td>2</td><td>9</td><td>4</td><td>3</td><td>2</td><td>—</td><td>—</td></tr>
<tr><td>10</td><td class="left">Aura of Courage</td><td>2</td><td>9</td><td>4</td><td>3</td><td>2</td><td>—</td><td>—</td></tr>
<tr><td>11</td><td class="left">Radiant Strikes</td><td>3</td><td>10</td><td>4</td><td>3</td><td>3</td><td>—</td><td>—</td></tr>
<tr><td>12</td><td class="left">Ability Score Improvement</td><td>3</td><td>10</td><td>4</td><td>3</td><td>3</td><td>—</td><td>—</td></tr>
<tr><td>13</td><td class="left">—</td><td>3</td><td>11</td><td>4</td><td>3</td><td>3</td><td>1</td><td>—</td></tr>
<tr><td>14</td><td class="left">Restoring Touch</td><td>3</td><td>11</td><td>4</td><td>3</td><td>3</td><td>1</td><td>—</td></tr>
<tr><td>15</td><td class="left">Subclass feature</td><td>3</td><td>12</td><td>4</td><td>3</td><td>3</td><td>2</td><td>—</td></tr>
<tr><td>16</td><td class="left">Ability Score Improvement</td><td>3</td><td>12</td><td>4</td><td>3</td><td>3</td><td>2</td><td>—</td></tr>
<tr><td>17</td><td class="left">—</td><td>3</td><td>14</td><td>4</td><td>3</td><td>3</td><td>3</td><td>1</td></tr>
<tr><td>18</td><td class="left">Aura Expansion</td><td>3</td><td>14</td><td>4</td><td>3</td><td>3</td><td>3</td><td>1</td></tr>
<tr><td>19</td><td class="left">Epic Boon</td><td>3</td><td>15</td><td>4</td><td>3</td><td>3</td><td>3</td><td>2</td></tr>
<tr><td>20</td><td class="left">Subclass feature</td><td>3</td><td>15</td><td>4</td><td>3</td><td>3</td><td>3</td><td>2</td></tr>

<div element="ID_WOTC_PHB24_CLASS_FEATURE_PALADIN_PALADINS_SMITE" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_PALADIN_CHANNEL_DIVINITY" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_PALADIN_PALADIN_SUBCLASS" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_PALADIN_ASI" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div element="ID_WOTC_PHB24_CLASS_FEATURE_PALADIN_ASI" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_PALADIN_ABILITY_SCORE_IMPROVEMENT" />

Comment on lines 99 to 101
<element name="Multiattack Defense" type="Archetype Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ARCHETYPE_FEATURE_RANGER_DEFENSIVE_TACTICS_MULTIATTACK_DEFENSE">
<compendium display="false" />
<supports>Defensive Tactics</supports>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<element name="Multiattack Defense" type="Archetype Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ARCHETYPE_FEATURE_RANGER_DEFENSIVE_TACTICS_MULTIATTACK_DEFENSE">
<compendium display="false" />
<supports>Defensive Tactics</supports>
<element name="Multiattack Defense" type="Archetype Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ARCHETYPE_FEATURE_RANGER_HUNTER_DEFENSIVE_TACTICS_MULTIATTACK_DEFENSE">
<compendium display="false" />
<supports>PHB24 Defensive Tactics</supports>

Comment on lines 109 to 110
<element name="Level 11: Superior Hunter's Prey" type="Archetype Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ARCHETYPE_FEATURE_RANGER_SUPERIOR_HUNTERS_PREY">
<requirements>!ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_SUPERIOR_HUNTERS_PREY</requirements>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<element name="Level 11: Superior Hunter's Prey" type="Archetype Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ARCHETYPE_FEATURE_RANGER_SUPERIOR_HUNTERS_PREY">
<requirements>!ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_SUPERIOR_HUNTERS_PREY</requirements>
<element name="Level 11: Superior Hunter's Prey" type="Archetype Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ARCHETYPE_FEATURE_RANGER_HUNTER_SUPERIOR_HUNTERS_PREY">
<requirements>!ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_HUNTER_SUPERIOR_HUNTERS_PREY</requirements>

<p>Once per turn when you deal damage to a creature marked by your <i>Hunter's Mark</i>, you can also deal that spell’s extra damage to a different creature that you can see within 30 feet of the first creature.</p>
</description>
<sheet alt="Superior Hunter's Prey" usage="1/Turn">
<description>When you deal damage to a creature marked by your Hunter's Mark, you can also deal that spell's extra damage to a different creature that you can see within 30ft of the first creature.</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<description>When you deal damage to a creature marked by your Hunter's Mark, you can also deal that spell's extra damage to a different creature that you can see within 30ft of the first creature.</description>
<description>When you deal damage to a creature marked by your Hunter's Mark, you can also deal that spell's extra damage to a different creature that you can see within 30ft. of the first creature.</description>

Comment on lines 118 to 119
<element name="Level 15: Superior Hunter's Defense" type="Archetype Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ARCHETYPE_FEATURE_RANGER_SUPERIOR_HUNTERS_DEFENSE">
<requirements>!ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_SUPERIOR_HUNTERS_DEFENSE</requirements>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<element name="Level 15: Superior Hunter's Defense" type="Archetype Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ARCHETYPE_FEATURE_RANGER_SUPERIOR_HUNTERS_DEFENSE">
<requirements>!ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_SUPERIOR_HUNTERS_DEFENSE</requirements>
<element name="Level 15: Superior Hunter's Defense" type="Archetype Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ARCHETYPE_FEATURE_RANGER_HUNTER_SUPERIOR_HUNTERS_DEFENSE">
<requirements>!ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_HUNTER_SUPERIOR_HUNTERS_DEFENSE</requirements>

Comment on lines 127 to 132
<!--Feature Replacement Grants-->
<element name="Hunter's Lore Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_HUNTERS_LORE" />
<element name="Hunter's Prey Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_HUNTERS_PREY" />
<element name="Defensive Tactics Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_DEFENSIVE_TACTICS" />
<element name="Superior Hunter's Prey Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_SUPERIOR_HUNTERS_PREY" />
<element name="Superior Hunter's Defense Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_SUPERIOR_HUNTERS_DEFENSE" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!--Feature Replacement Grants-->
<element name="Hunter's Lore Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_HUNTERS_LORE" />
<element name="Hunter's Prey Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_HUNTERS_PREY" />
<element name="Defensive Tactics Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_DEFENSIVE_TACTICS" />
<element name="Superior Hunter's Prey Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_SUPERIOR_HUNTERS_PREY" />
<element name="Superior Hunter's Defense Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_SUPERIOR_HUNTERS_DEFENSE" />
<!--Feature Replacement Grants-->
<element name="Hunter's Lore Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_HUNTER_HUNTERS_LORE" />
<element name="Hunter's Prey Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_HUNTER_HUNTERS_PREY" />
<element name="Defensive Tactics Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_HUNTER_DEFENSIVE_TACTICS" />
<element name="Superior Hunter's Prey Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_HUNTER_SUPERIOR_HUNTERS_PREY" />
<element name="Superior Hunter's Defense Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_RANGER_HUNTER_SUPERIOR_HUNTERS_DEFENSE" />

Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Comment on lines +156 to +157
<spellcasting name="Ranger" ability="Wisdom" allowReplace="true">
<list>Ranger</list>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<spellcasting name="Ranger" ability="Wisdom" allowReplace="true">
<list>Ranger</list>
<spellcasting name="Ranger" ability="Wisdom" prepare="true">
<list known="true">Ranger</list>

Rangers now prepare from their spell list

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while that is correct de jure, de facto Ranger (just like other spellcasters that were changed to prepare-casting) still use known-casting mechanics. So this change would only make it harder to deal with it.

Comment on lines +174 to +185
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="1" number="2" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="2" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="3" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="4" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="5" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="7" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="9" number="2" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="11" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="13" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="15" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="17" number="2" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="19" spellcasting="Ranger" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="1" number="2" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="2" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="3" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="4" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="5" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="7" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="9" number="2" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="11" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="13" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="15" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="17" number="2" spellcasting="Ranger" />
<select type="Spell" name="Spell (Ranger)" supports="$(spellcasting:list),$(spellcasting:slots)" level="19" spellcasting="Ranger" />
<stat name="ranger:spellcasting:prepare" value="2" level="1" />
<stat name="ranger:spellcasting:prepare" value="1" level="2" />
<stat name="ranger:spellcasting:prepare" value="1" level="3" />
<stat name="ranger:spellcasting:prepare" value="1" level="4" />
<stat name="ranger:spellcasting:prepare" value="1" level="6" />
<stat name="ranger:spellcasting:prepare" value="2" level="8" />
<stat name="ranger:spellcasting:prepare" value="1" level="10" />
<stat name="ranger:spellcasting:prepare" value="1" level="12" />
<stat name="ranger:spellcasting:prepare" value="1" level="14" />
<stat name="ranger:spellcasting:prepare" value="2" level="16" />
<stat name="ranger:spellcasting:prepare" value="1" level="18" />

Copy link
Contributor

@NickVendel NickVendel Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ranger 2024

4 participants