This repository was archived by the owner on Mar 28, 2023. It is now read-only.
Buffer-style message logging as an alternative to database message logging#131
Open
Buffer-style message logging as an alternative to database message logging#131
Conversation
Member
|
Hmmm. I wonder if this is a better approach compared to pruning the database to keep it within either 250 entries or thirty minute's worth of entries, whichever is less. If one keeps it in the database, any queries made against the log can stay unified as part of the database API. |
Member
Author
|
The idea with keeping the buffer in memory is privacy - users can be assured that their messages will only be stored if a problem arises (as the buffer is only accessible via mod call), and they will otherwise be pushed out of the buffer and vanish into the ether. |
Member
|
It's possible to direct IC logging to an in-memory SQLite database |
Member
Author
|
Okay but I don't know how to do that so it doesn't exist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should help save space in the long run, and can quell privacy concerns where user message storage is concerned. Long overdue (read: i wrote 90% of this and then forgot about it for months) refactor of #123.