fix: wrap buffer.subarray() calls with Buffer.from()#233
Merged
matthewjablack merged 2 commits intomasterfrom Oct 20, 2025
Merged
fix: wrap buffer.subarray() calls with Buffer.from()#233matthewjablack merged 2 commits intomasterfrom
matthewjablack merged 2 commits intomasterfrom
Conversation
- fix ContractInfo deserialization for React Native - fix DlcAccept CET adaptor signature parsing - fix DlcOffer nextBytes buffer reading compatibility - fix DlcSign funding signature deserialization - ensure all buffer operations work in React Native
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
React Native's Buffer implementation doesn't handle
subarray()the same way as Node.js, causing deserialization failures in DLC messaging components when used in React Native environments.Solution
buffer.subarray()calls withBuffer.from()to ensure proper Buffer instancesnextBytesbuffer reading inDlcOffer.tsby usingBufferReaderinstead of direct buffer methodsChanges
ContractInfo.tsdeserialization for React NativeDlcAccept.tsCET adaptor signature parsingDlcOffer.tsnextBytes buffer reading compatibilityDlcSign.tsfunding signature deserializationTesting
Fixes React Native compatibility issues without breaking existing functionality.