-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs: fix api install instructions and project structure #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix api install instructions and project structure #433
Conversation
Summary of ChangesHello @danielfrey63, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves inconsistencies within the project's documentation. Specifically, it updates the repository's main Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the documentation to reflect the use of Poetry for backend dependency management and fixes the installation command. The changes are accurate and improve the clarity of the setup instructions. I've provided one minor suggestion to improve the formatting and alignment in the project structure diagram in the main README file.
| │ ├── pyproject.toml # Python dependencies (Poetry) | ||
| │ └── poetry.lock # Locked Python dependency versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alignment of the comments for the new files is slightly off compared to the rest of the file structure diagram. For better readability and consistency, you can adjust the spacing to align the comments with the other entries.
| │ ├── pyproject.toml # Python dependencies (Poetry) | |
| │ └── poetry.lock # Locked Python dependency versions | |
| │ ├── pyproject.toml # Python dependencies (Poetry) | |
| │ └── poetry.lock # Locked Python dependency versions |
Summary
This PR fixes two documentation inconsistencies around backend dependency installation and the repository structure overview.
Changes
api/) uses Poetry (pyproject.toml + poetry.lock) instead of arequirements.txt.poetry installpoetry install -C apiWhy
poetry installfrom the repository root fails because there is nopyproject.tomlin the root directory. The backend Poetry project lives underapi/.api/requirements.txt, which is not the actual dependency source of truth for the backend.How to verify
python -m pip install poetry==2.0.1 && poetry install -C apiScope
Documentation-only change. No runtime / code changes.