Skip to content

Adding the option to not-animate/animate the selection #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterpaulis wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding the option to not-animate/animate the selection #302

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76a8cb3
Adding the option to not-animate/animate the selection
peterpaulis Feb 3, 2022
600ac57
Improving the .top display, respecting the safeArea margins and keyboard
peterpaulis Sep 26, 2022
85d09ac
Merge pull request #1 from peterpaulis/peterpaulis-patch-1
peterpaulis Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 30 additions & 7 deletions DropDown/src/DropDown.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,13 +749,36 @@ extension DropDown {
let x = anchorViewX + topOffset.x
var y = (anchorViewMaxY + topOffset.y) - tableHeight

let windowY = window.bounds.minY + DPDConstant.UI.HeightPadding
var windowY = window.bounds.minY
if #available(iOS 11.0, *) {
windowY += window.safeAreaInsets.top
} else {
windowY += DPDConstant.UI.HeightPadding
}

if y < windowY {
offscreenHeight = abs(y - windowY)
y = windowY
} else {
let maxY = y + tableHeight

var windowMaxY = window.bounds.maxY - offsetFromWindowBottom
if #available(iOS 11.0, *) {
windowMaxY -= window.safeAreaInsets.bottom
} else {
windowMaxY -= DPDConstant.UI.HeightPadding
}

if y < windowY {
offscreenHeight = abs(y - windowY)
y = windowY
let keyboardListener = KeyboardListener.sharedInstance
let keyboardMinY = keyboardListener.keyboardFrame.minY - DPDConstant.UI.HeightPadding

if keyboardListener.isVisible && maxY > keyboardMinY {
offscreenHeight = abs(maxY - keyboardMinY)
} else if maxY > windowMaxY {
offscreenHeight = abs(maxY - windowMaxY)
}
}
let width = self.width ?? (anchorView?.plainView.bounds.width ?? fittingWidth()) - topOffset.x

return (x, y, width, offscreenHeight)
Expand Down Expand Up @@ -973,10 +996,10 @@ extension DropDown {
}

/// (Pre)selects a row at a certain index.
public func selectRow(at index: Index?, scrollPosition: UITableView.ScrollPosition = .none) {
public func selectRow(at index: Index?, scrollPosition: UITableView.ScrollPosition = .none, animated: Bool = true) {
if let index = index {
tableView.selectRow(
at: IndexPath(row: index, section: 0), animated: true, scrollPosition: scrollPosition
at: IndexPath(row: index, section: 0), animated: animated, scrollPosition: scrollPosition
)
selectedRowIndices.insert(index)
} else {
Expand Down