Fix fishing servers not being detected correctly / show fishing upgrade icons also outside of fishing servers #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
violine1101
changed the title
Contributor
Author
|
Please merge #209 first, I'll then rebase on top of that. |
Owner
|
hiya tyvm :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was reported on Discord. This PR fixes detection of
Game.FISHING.It also removes the dependency of icons for the available fishing upgrades from currently being on a fishing server, since this UI can also be accessed from outside the fishing servers.
Also added some extra annotations to the
Gameclass, and removed some unused code.