Update CommonVertexElement.java to fix offsets#545
Open
Meamzy wants to merge 1 commit intoAsek3:1.20/devfrom
Open
Update CommonVertexElement.java to fix offsets#545Meamzy wants to merge 1 commit intoAsek3:1.20/devfrom
Meamzy wants to merge 1 commit intoAsek3:1.20/devfrom
Conversation
There is an issue with the minecraft source code where the offsets field is declared private and can't be accessed by the CommonVertexElement.java: at `var offsets = format.offsets;` Decompiled minecraft code with infused forge: private final IntList offsets = new IntArrayList();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue with the minecraft source code where the offsets field is declared private and can't be accessed by the CommonVertexElement.java:
at
var offsets = format.offsets;Decompiled minecraft code with infused forge:
at VertexFormat.java
private final IntList offsets = new IntArrayList();But the VertexFromat class has a getOffset method that uses indexes:
public int getOffset(int index) { return offsets.getInt(index); }So I've used that method to get the offsets inside of the for loop.
The initial error I've got while trying to run minecraft:
Minecraft version 1.20.1
Forge version: forge-1.20.1-47.1.0
Related issue:
#543